Repository navigation
localize new images into an existing reconstruction #175
Description
Hi @paulinus ,I want to localize new images into an existing reconstruction,so I try to modify the incremental_reconstruction to make it go like that , so that I just detect features for the new image,then match it with the images that have done before,then do the incremental_reconstruction,but for the same data,if I do like this ,it usually can't be reconstructed correctly,and even some images can't be added to the reconstruction,but if I don't do some changes,it can get the location,and the location is right,can you tell me why? Why the new image cannot be added to the existing reconstruction? I was confused by this question for a long time,looking forward to your reply,thanks!
Activity
paulinus commentedon May 14, 2017
Hi @Dorothy-2016,
the incremental_reconstruction pipeline uses the tracks graph to understand the correspondence between features from different images. If you add a new image and compute matches for it, you will need to update the tracks graph accordingly.
This will require extending existing tracks in case a feature point matches points on it. And also creating a new track in case a new feature point matches an old feature point that does not belong to any track yet.
Could that be the part you are missing, or you are already doing that?
Dorothy-2016 commentedon May 15, 2017
Thank you for your reply!@paulinus, I get the meaning of your advice,Does the step of create_tracks do this job?I think if I give the whole matching results which include the new frame to this step,I can get the whole tracks_graph including the new frame,or do I understand it wrong?
Dorothy-2016 commentedon May 15, 2017
and I also have another question,even though the time of the whole sfm pipeline is faster than other methods I have tried,I need to improve the speed to run on mobile phone,I found that the detection and matching part costs more time than other parts,so I modify the feature from sift to orb,and match the current frame only to its neighbor one frame before it,what the question is no matter how many points orb can detect,the reconstruction step cannot get the right results,I found the pairs of compute_image_pairs was always null,I'm confused, can you give me some advice?Thank you very much!
paulinus commentedon May 15, 2017
ORB features should work fine for SfM. Do you know if the matches generated are correct? You can plot them using
Did you modify
features.pyto add ORB? It would be great to integrate those changes once it is working.Dorothy-2016 commentedon May 16, 2017
yes,I have modified the features.py to add ORB using opencv, I also use plot_features to see the points that have been detected,but the result is not as good as sift or surf,I set the max number of orb feature points to 10000, here is what I get :
However,when I use sift,the result is like these:
and as what you adviced,I test the plot_matches,the result is as follows:
from this compairation,I'm a little confused about the result of orb,it apparently shows that the number of orb is bigger than sift,while looking at the result picture,I think sift is much more than orb,and the features on the floor are aslo detected
Here is the code that add orb:
def extract_features_orb(image, config):detector = cv2.ORB_create(nfeatures=10000)points = detector.detect(image, None)points, desc = detector.compute(image, points)if config.get('feature_root', False): desc = root_feature(desc, True)points = np.array([(i.pt[0], i.pt[1], i.size, i.angle) for i in points])return points, desccan u help me find where the problem is?Thanks!
Dorothy-2016 commentedon May 16, 2017
I have uploaded the dataset here https://drive.google.com/drive/folders/0B9KhOFLoD2ytdnowc0JjUUwzNEE
BrookRoberts commentedon May 19, 2017
Have just seen this - not sure how much we might be overlapping but yesterday I started looking at making an easy way to extend existing reconstructions.
Was planning on seeing how easy it was to
a) have opensfm default more to not recalculating parts of the reconstruction that are already made
b) make it easy to both add new images to a reconstruction, and locate images in a reconstruction without adjusting the placement of the rest (possibly a faster way of just localising new images if you trust the initial reconstruction)
@paulinus Does any of this stuff already exist? (I know e.g. incremental_reconstruction is structured in a way such that most of this work is done) Would you agree that some of this stuff would be useful core features?
BrookRoberts commentedon May 24, 2017
#178 allows you to add new images to an existing reconstruction.
YanNoun commentedon Mar 15, 2021
Duplicate of https://github.com/mapillary/OpenSfM/pull/178/files, closing.