Track the Lightning CSS version in the gem version - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes the gem version mirror the Lightning CSS release it packages, so gem v1.33.0 bundles Lightning CSS v1.33.0, and the upstream workflow bumps that version along with the dependency.
Lightning CSS numbers its crate differently from its releases. Every version on crates.io is
1.0.0-alpha.N, with no stable release ever published, while the same build is taggedv1.33.0and ships on npm as1.33.0.Following the crate would make every release a RubyGems prerelease, which
bundle add lightningcssskips, so the gem follows the release instead:The workflow reads the latest release from GitHub, then reads
Cargo.tomlat that tag to learn which crate the release carries: