Skip to content

[Navigation drawer] Navigation drawer has square corners on pre-Q devices because ColorStateListDrawable is not supported #3529

Closed

Description

@manabu-nakamura

Description: The navigation drawer (1.11.0-alpha02) has square corners.
Screenshot_20230818_133510

Expected behavior: The navigation drawer has rounded corners like the navigation drawer (1.11.0-alpha01).
Screenshot_20230818_133417

Minimal sample app repro: Catalog app

Android API version: 34

Material Library version: 1.11.0-alpha02

Device: Emulator 32.1.14 (API 32)

Activity

  1. self-assigned this
    on Aug 18, 2023
  2. imhappi commented on Aug 21, 2023

    @imhappi
    Contributor

    Going to re-open this and update the title since the fix is only for Q+ devices

    pre-Q devices will require a more involved solution

  3. changed the title [-][Navigation drawer] Navigation drawer has square corners[/-] [+][Navigation drawer] Navigation drawer has square corners on pre-Q devices because ColorStateListDrawable is not supported[/+] on Aug 21, 2023
  4. imhappi commented on Aug 21, 2023

    @imhappi
    Contributor

    @pekingme just putting this on your radar for any upcoming work on the fragile ColorDrawable checking

  5. pekingme commented on Aug 28, 2023

    @pekingme
    Contributor

    We have #3538 to add the ColorStateListDrawable support. But this issue is caused by leveraging CSL to achieve the custom tone from the dynamic palettes for tonal surface color. Closing this issue since it won't be an issue for pre-Q devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions