Skip to content

SOLEIL: add PX1 BL - #2740

Merged
willend merged 6 commits into
mccode-dev:mainfrom
farhi:2026-10-soleil-add-px1-1
Oct 19, 2026
Merged

willend merged 6 commits into
mccode-dev:mainfrom
farhi:2026-10-soleil-add-px1-1

Conversation

@farhi

@farhi farhi commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Free-form text area

This PR adds the PX1 beam-line at SOLEIL. Derived from PX2a model.
Compiles OK.


Declaration of use of AI-tools

  • Please add a checkmark here if you used AI-tools during the work for this contribution
  • Furter, please describe how / where and for what the tools were used:

Development OS / boundary conditions

Please describe what OS you developed and tested your additions on, and if any special dependencies are required:


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution includes a new instrument file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)
    • I have ensured that basic use of the instrument is OK (e.g. it compiles?)
    • ... and provided reasonable default parameters in that instrument that produce reasonable output
    • ... and maybe even added a %Example: line to describe expected behaviour
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised
    • My new instrument is added within the examples hierarchy in a folder in the style of examples/ESS/New_stuff/New_stuff.instr
    • My new instrument has a new, unique filename, not clashing with existing example instruments
    • My new instrument requires a data/input file. If the datafile is specific for my instrument I have left it in the same example folder, but if general use I have placed it in the global data folder.

@farhi

farhi commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

This PX1 model seems to have an issue. Compiles OK but computation is really long.
needs further checks.

@willend

willend commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

mxdoc screenshots
Screenshot 2026-10-04 at 07 20 36
Screenshot 2026-10-04 at 07 20 23

@willend

willend commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

@farhi the CI logs also reveal that the %Example line is off
https://github.com/mccode-dev/McCode/actions/runs/37141573354/job/111256930827?pr=2740#step:32:208

@willend

willend commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Copy-pasted from last run

Running tests / getting status...
SOLEIL_PX1  :   Display OK (1s)
SOLEIL_PX1  : 108.99    [val: 108927000000000.0 / 1750000000000.0 = 6224 %] <--- BIG DISCREPANCY??
 - Test 1 plots generated OK
SOLEIL_PX1_2: 119.00    [val: 13739300000000.0 / 3800000000000000.0 = 0 %] <--- BIG DISCREPANCY??
 - Test 2 plots generated OK

@willend
willend marked this pull request as draft October 4, 2026 16:30
@willend
willend marked this pull request as ready for review October 19, 2026 14:22
@willend
willend merged commit 600399b into mccode-dev:main Oct 19, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants