Conversation
yordan-st
marked this pull request as ready for review
September 15, 2026 14:46
yordan-st
force-pushed
the
fix/WC-3564_tree-node-stuck-spinner-microflow
branch
from
September 15, 2026 14:54
1ab005e to
44f3740
Compare
This comment has been minimized.
This comment has been minimized.
gjulivan
force-pushed
the
fix/WC-3564_tree-node-stuck-spinner-microflow
branch
from
September 17, 2026 09:03
a267756 to
8b1c93c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Tree Node v2 stored an expand-icon "loading" state per node and resolved it via a broken heuristic (a node's id reappearing in some later datasource delivery), which a microflow datasource breaks in two ways: a permanently stuck loading spinner when "Start expanded" is Yes, and an unrelated node silently and permanently losing its expand icon when a sibling is expanded (WC-3564). The spinner is now a pure render-time decision driven by the datasource's own
status, never stored per node.Manual verification of that fix surfaced two further pre-existing bugs in the same "preload one level ahead" mechanism, fixed in the same PR since they were found and understood during the same pass: a node's first expand didn't preload its own children's children (needed a collapse+re-expand to reveal a deeper tier), and the automatic root-expansion path for "Start expanded" = Yes only went one level deep instead of cascading to the tree's real depth (every level defaults to expanded in that mode, not just roots).
What should be covered while testing?
parentAssociationconfigured) — spot-check unaffected, this change only touches v2 code pathsNo XML changes; this is a bug fix restoring intended behavior, not a new feature — no docs PR needed. Changelog entries already added under
[Unreleased].Ticket: WC-3564