Conversation
Every other boolean get in this codebase replies "on"/"off": radio.rxgain (CommonRadioPrefs.cpp) and radio.fem.rxgain (HeltecV4Board.cpp). "get wifi.enabled" was the one outlier, replying with a bare "1"/"0". Note for reviewers: this changes an existing CLI reply format. If any client already parses the raw "1"/"0" value, this would be a breaking change for it -- flagging this explicitly rather than assuming it's risk-free. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
You should probably remove the comments. |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Blake-Latchford
approved these changes
Sep 18, 2026
|
Oh, have you actually executed the code and verified it does what you expect? |
Blake-Latchford
suggested changes
Sep 18, 2026
Blake-Latchford
left a comment
Blake-Latchford
left a comment
There was a problem hiding this comment.
Describe testing completed on hardware.
Member
|
This would then make the The other So if this was to be changed for the getter, it should probably be changed for the setter as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changes
get wifi.enabledto replyon/offinstead of a bare1/0.Why
Every other boolean
getin this codebase replieson/off:radio.rxgain(CommonRadioPrefs.cpp) andradio.fem.rxgain(HeltecV4Board.cpp).get wifi.enabledwas the one outlier.A question before merging
This changes an existing CLI reply format. If any client (app, script,
meshcore-cli, etc.) already parses the raw1/0value, this would be a breaking change for it. Flagging this explicitly rather than assuming it's risk-free -- happy to adjust the approach if there's a compatibility concern I'm not aware of.Compile-verified against current
dev(heltec_v4_companion_radio_ble).🤖 Generated with Claude Code