Skip to content

Ensure correct sleep in 'rmw_wait' (backport #344) - #345

Merged
David-LP99 merged 1 commit into
kiltedfrom
mergify/bp/kilted/pr-344
Oct 6, 2026
Merged

David-LP99 merged 1 commit into
kiltedfrom
mergify/bp/kilted/pr-344

Conversation

@mergify

@mergify mergify Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Description

Because of truncation and rounding issues, there are some edge cases where rmw_wait() can sleep for less time than the indicated.

Main changes

  • Round non-zero ended nanosecond times up to the next millisecond
  • Since uxr_millis() rounds the clock time down (e.g. 100.9 ms to 100 ms), one more loop iteration is often needed when now == deadline
    This is an automatic backport of pull request Ensure correct sleep in 'rmw_wait' #344 done by Mergify.

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
(cherry picked from commit c3257d4)
@mergify

mergify Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.85%. Comparing base (efbd887) to head (d569c25).
⚠️ Report is 1 commits behind head on kilted.

Additional details and impacted files
@@            Coverage Diff             @@
##           kilted     #345      +/-   ##
==========================================
- Coverage   55.63%   54.85%   -0.78%     
==========================================
  Files         102      101       -1     
  Lines        6072     5897     -175     
  Branches     1011      929      -82     
==========================================
- Hits         3378     3235     -143     
+ Misses       2345     2327      -18     
+ Partials      349      335      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@David-LP99
David-LP99 merged commit 9d49b4d into kilted Oct 6, 2026
4 checks passed
@David-LP99
David-LP99 deleted the mergify/bp/kilted/pr-344 branch October 6, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants