Repository navigation
Ensure correct sleep in 'rmw_wait' (backport #344) - #347
Merged
Merged
Conversation
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> (cherry picked from commit c3257d4)
Contributor
Author
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## humble #347 +/- ##
=======================================
Coverage 55.00% 55.00%
=======================================
Files 99 99
Lines 5898 5898
Branches 932 932
=======================================
Hits 3244 3244
Misses 2327 2327
Partials 327 327 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because of truncation and rounding issues, there are some edge cases where
rmw_wait()can sleep for less time than the indicated.Main changes
uxr_millis()rounds the clock time down (e.g. 100.9 ms to 100 ms), one more loop iteration is often needed whennow == deadlineThis is an automatic backport of pull request Ensure correct sleep in 'rmw_wait' #344 done by Mergify.