Skip to content

favicon.ico #28

Description

@sean-roberts

I've been using chrome to open up views to test and it's requesting for favicon.ico. Is there something we could/should do here? I think this could be a common usage pattern for people trying out the project/testing it.

So some sort of filtering or blacklist?

Activity

  1. mxstbr commented on Jan 15, 2017

    @mxstbr
    Member

    Yeah I've been getting that too, but I think it's largely inconsequential as it only happens when you open the service itself in a browser.

    Generally, when used something like this:

    fetch('myservice.com/bla')

    No favicon visit will be counted, so I think this is fine? It mostly only applies to us developers of micro-analytics.

  2. sean-roberts commented on Jan 15, 2017

    @sean-roberts
    CollaboratorAuthor

    Yeah, though I think it's worth saying that it will probably apply to any developer looking to see how the service works. Because that's just so easy of a test to play around.

    I wonder if there is a way to support user-supplied filtering logic of requests going into the service. I think this is one use case but there might be plenty of others like IP whitelisting, blocking of endpoints that are being abused by a malicious 3rd party, any request that contains a "password" field, etc.

  3. mxstbr commented on Jan 15, 2017

    @mxstbr
    Member

    Yeah this'll probably tie into #11. Maybe we need some sort of general extensibility?

  4. sean-roberts commented on Jan 15, 2017

    @sean-roberts
    CollaboratorAuthor

    I think so

  5. relekang commented on Jan 15, 2017

    @relekang
    Member

    We can maybe add this to the nginx example?

      location = /favicon.ico {
          access_log off;
          log_not_found off;
          return 204;
      }
    
  6. sean-roberts commented on Jan 15, 2017

    @sean-roberts
    CollaboratorAuthor

    Not a bad idea either!

  7. mxstbr commented on Jan 15, 2017

    @mxstbr
    Member

    I like that, simple solution! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions