Repository navigation
Python 3.11 adoption opportunities: claim one improvement at a time #3166
Description
Is your feature request related to a problem? Please describe.
PyRIT now requires Python >=3.11 (currently <3.15), and Ruff targets py311. We can use Python 3.11 features consistently across supported versions, simplify older compatibility patterns, and improve typing, diagnostics, and async lifecycle management. Some features are already partially adopted; the opportunities below are investigations, not instructions to replace every existing pattern.
Describe the solution you'd like
How to participate: ONE opportunity at a time
Claim exactly ONE checklist item at a time by commenting on this issue thread with its ID (for example, P311-01) and a short description of what you intend to investigate. Do not start multiple items or claim a bundle. Wait for confirmation here before treating the item as reserved. Claims are processed in comment order, and this issue is checked approximately every three hours.
- You must open a PR within five days (120 hours) of your claim comment. The table below records the due date. If no PR is opened by then, the claim expires, the item becomes available, and your issue assignment is removed if you have no other active contribution on this issue. You can claim it again if it is still available.
- Opening a PR within the deadline retains your claim while that PR is active. You cannot claim another item until your current PR is merged or the current contribution is explicitly released/closed.
- Link this issue and the item ID in your PR description. Keep the PR focused on that one opportunity. Follow repository instructions and add relevant behavior/type-checking coverage.
- Investigate first. Preserve public contracts and intended behavior. If a feature is not a good fit, explain why on this thread rather than forcing a change. An investigation can conclude that no code change is appropriate.
- A PR opened without a prior claim will be highlighted to Roman Lutz (@romanlutz). If the item is unclaimed, we can link the PR and assign the item to its author. If someone else has already claimed it or another PR overlaps, Roman Lutz (@romanlutz) will assess how to proceed; no existing claim will be displaced automatically.
- Checkboxes mean completed, not claimed. Check an item only after its PR is merged, or after a maintainer explicitly accepts a no-change investigation. Ownership and PR links are tracked separately below.
Opportunity checklist
Typing
- P311-01: Extend
typing.Selfadoption. Investigate older same-concrete-class factories and fluent APIs, such aspyrit/common/yaml_loadable.py:YamlLoadable.from_yaml_file. Replace bound-TypeVar boilerplate only where it really modelsSelf; retain independent generic parameters. Merged scope: #3194 covers YAML/seed and scorer-metrics loaders, strategy-context copying, and technique collections, with type-regression coverage. Additional merged scope: #3201 covers the threeMessagefactories andAtomicAttackIdentifier.build, including subclass type-regression tests. Additional merged scope: #3266 coversSeedDataset.from_dict,MessageScorable.from_message, andContentScorable.from_message, with subclass runtime andassert_typecoverage and unchanged validation. Remaining cases (available for a new claim): investigateMessagePiece.adversarial_placeholderinpyrit/models/messages/message_piece.pyandAttackTechniqueSeedGroup.from_system_prompt/from_messagesinpyrit/models/seeds/attack_technique_seed_group.py. These still construct throughclsbut annotate their concrete base class. Pick one focused factory family, preserve validation, and add subclass runtime/type-regression coverage. Do not mechanically changeMessage.duplicate,SeedDataset.from_yaml_file, or other loaders that intentionally construct a fixed base class; retain independent generic parameters. - P311-02: Improve dictionary contracts with
TypedDict,Required, andNotRequired. Investigate internal metadata/provider payloads currently typed asdict[str, Any]. Distinguish absent keys from nullable values.RawAnalyticsProfilealready provides prior art. Do not replace Pydantic runtime validation. - P311-03: Add exhaustive dispatch checks with
assert_never/Never. Investigate closed enum/union dispatch for outcomes, states, modalities, or capabilities so added cases surface during type checking. Apply only where handling is genuinely exhaustive, not to intentionally open extension points. - P311-04: Add type-regression checks with
assert_type. Investigate registry factories, generic results, decorators, and subclass-returning APIs. Ensure checks run through the type checker;assert_typeis not a runtime assertion. - P311-05: Investigate
LiteralStringat static-template boundaries. Consider developer-authored SQL or command templates where the type checker can enforce the distinction. Confirm checker support. This is not runtime sanitization and never replaces parameterized SQL. - P311-06: Investigate
TypeVarTuple/Unpackfor variadic types. Look for a concrete heterogeneous-tuple or numerical/multimodal API that benefits. Do not add variadic complexity without a real need or assume this automatically checks NumPy shapes. Features standardized after 3.11 still need compatible backports. - P311-07: Investigate generic
TypedDict/NamedTuplecontainers. Identify payload containers whose content type should be parameterized. GenericTypedDictin analytics result analysis provides existing prior art.
Async execution and diagnostics
- P311-08: Enrich propagated exceptions with
BaseException.add_note. Add useful execution, technique, dataset, or conversation context while preserving exception types and tracebacks. Notes appear in formatted tracebacks, notstr(error). Exclude secrets and sensitive prompt content. Merged scope: #3175 adds dataset/provider notes to concurrent provider-fetch failures. Additional merged scope: #3277 adds scenario and atomic-attack names to caught worker-pool exceptions inScenario._execute_atomic_attacks_parallel_async, preserving the original exceptions and existing single/grouped failure behavior. Regression coverage checks grouped notes and single-failure identity. Additional merged scope: #3281 labels cached-backend and analytics close failures inclose_services_async, preserving the original exceptions, cancellation and single/grouped behavior. Remaining focused investigation (claimed by Slai.life (@huong8373tt-beep); #3333 open):RuntimeLifecycle._shutdown_runtime_asyncinpyrit/backend/services/runtime_lifecycle.pycollects scenario-service shutdown and memory-disposal failures alongside drained-request and service-close errors under one generic runtime-shutdown group. Investigate safe static phase-name notes for those still-unlabelled phases, without duplicating the service-close context already added by MAINT: Add service shutdown error context #3281. Preserve exception identity/type/tracebacks, existing notes, cleanup order, cancellation and group shape. Regression entry points:tests/unit/backend/test_runtime_lifecycle.py. Do not annotate every exception or include secrets, prompts or seed content. - P311-09: Use scoped operation timeouts with
asyncio.timeout. Investigate multi-await operations that should share one timeout scope instead of restarting a timeout for every step. Existing analytics, objective-generation, observation, and A2A usage provides prior art. Preserve cancellation and cleanup behavior. Merged scope: #3205 gives each Copilot receive loop one overall budget across streamed messages, with separate handshake/response budgets and cancellation/cleanup coverage. Completed: #3239 givesWebSocketTarget._initialize_connection_asyncone separate receive budget across all discarded initial messages, with aggregate-budget and cancellation/connection-cleanup coverage. Initialization sends, restoration, and normal responses retain their separate scopes. Current timeout-site assessment found no further worthwhile shared-budget migration: remainingwait_forcalls bound individual operations, explicitly per-attempt probes, or already use a shared remaining deadline. Do not mechanically replace those calls. - P311-10: Propagate absolute deadlines with
asyncio.timeout_at. Investigate nested operations/retries that should share one monotonic-clock deadline. Distinguish operation deadlines from per-step timeouts and keep cleanup semantics explicit. - P311-11: Investigate structured concurrency with
asyncio.TaskGroup. Identify parent-scoped child tasks with appropriate fail-fast semantics. The message-send service already uses it. It is not a blanketgatherreplacement or a concurrency limiter: sibling cancellation and exception shapes differ. Preserve ordered results and the deliberate cancellation/cleanup behavior inpyrit/common/task_utils.py. - P311-12: Investigate
ExceptionGroup/except*handling. Preserve multiple failures and, where useful, handle matching subsets without losing other errors. Groups already exist in scenario execution and service shutdown. Carefully assess public exception contracts and cancellation (BaseExceptionGroup). - P311-13: Investigate explicit task context with
asyncio.create_task(..., context=...). Identify background operations that need selected tracing/execution ContextVars or a clean context. Default task creation already copies the current context; do not change it gratuitously. - P311-14: Investigate
asyncio.Runnerfor synchronous entry points. Consider multiple top-level calls sharing one managed loop/context in a shell or lifecycle harness. This does not permit nested loops inside an already-running notebook event loop. Preserve resource and loop ownership.
Standard-library simplifications
- P311-15: Parse project TOML with
tomllib. Investigate replacing the version-extraction regex inbuild_scripts/stamp_compatibility.pywith structured access toproject.version. Preserve validation/provenance behavior.tomllibreads TOML; it does not write it. Completed: #3208 replaces the version regex with structuredproject.versionparsing and covers table ordering, quoting, invalid metadata, and provenance errors. - P311-16: Simplify ISO timestamp parsing. Investigate removing trailing-
Zcompatibility rewrites, such as_RemoteDatasetLoader._parse_datetime, because 3.11 parses validZtimestamps directly. Preserve timezone and accepted-input contracts. Do not edit immutable historical Alembic revisions merely for cleanup. Completed: #3176 removes the active loader shim and preserves invalid/non-string fallback behavior. Post-merge search found no other actionable ISO-parsing compatibility shims inpyritorbuild_scripts; the remaining rewrite in historical migrationd7e9f1a3b5c6is intentionally immutable. - P311-17: Assess
enum.StrEnumfor appropriate enums. It is already used for harm categories and message-send models. Existingstr, Enummigrations can changestr(member)and formatting, and Ruff's automatic replacement is deliberately disabled. Focus on cases where string behavior is intended and compatibility is understood. - P311-18: Investigate atomic regex groups and possessive quantifiers. Consider
(?>...),*+, or++in a concrete scorer/parser pattern with unnecessary backtracking on large model outputs. Measure behavior and performance; these constructs change matching semantics and are not a universal regex-safety fix. - P311-19: Investigate
hashlib.file_digestfor whole-file hashes. Consider classifier artifact verification or other complete-file checks. Keep blocking I/O off async paths. Do not replace bounded evidence-reading loops that enforce budgets/cancellation and retain content. - P311-20: Investigate
inspect.getmembers_staticfor safe introspection. Identify registry inspection that should avoid invoking descriptors/properties. It intentionally bypasses dynamic lookup and lazy exports, so verify the discovery contract before adoption.
SQLite-specific memory opportunities
These must stay in the SQLite-specific memory/driver layer and preserve portable SQL Server behavior. Check what SQLAlchemy/aiosqlite exposes before choosing an implementation.
- P311-21: Improve SQLite error handling using extended error codes/names. Analytics already checks
sqlite_errorcodefor plainSQLITE_BUSY. Investigate other real cases where structured codes are preferable to error-message matching, including distinctions such as stale snapshots. - P311-22: Investigate SQLite connection
getlimit/setlimit. Identify a real need for connection-level runtime limits and how limits interact with pooling and workloads. Avoid arbitrary limits that break existing behavior. - P311-23: Investigate SQLite custom window functions. Assess whether an actual analytics use case benefits from
create_window_function, with SQLite runtime support, driver integration, and portability considered. Prefer existing SQL when sufficient. - P311-24: Investigate incremental SQLite BLOB I/O. Assess whether any actual large-BLOB storage path benefits from
blobopen. Do not redesign media storage just to use this API; a no-change conclusion may be appropriate. - P311-25: Investigate SQLite database serialization/deserialization. Assess a concrete snapshot/test/export use case for
serialize/deserialize, including runtime availability, memory cost, concurrency, and driver boundaries.
Claim and PR tracking
The tracker is authoritative for per-item ownership; GitHub issue assignees are the aggregate set of active contributors. Available items have no active tracker row. Preserve released/expired rows as history when updating the tracker.
| Item | Contributor | Claim comment / source | Claimed on | PR due | PR | Status |
|---|---|---|---|---|---|---|
| P311-08 | Slai.life (@huong8373tt-beep) | Claim comment | 2026-10-19 | 2026-10-24 | #3333 | PR open within deadline; runtime-shutdown phase context reserved |
| P311-08 | Slai.life (@huong8373tt-beep) | Claim comment | 2026-10-17 | 2026-10-22 | #3281 | ✅ PR merged 2026-10-19; contribution complete; runtime-shutdown phase context remains available, reservation released |
| P311-08 | Slai.life (@huong8373tt-beep) | Claim comment | 2026-10-16 | 2026-10-21 | #3277 | ✅ PR merged 2026-10-17; contribution complete; service-shutdown context remains available, reservation released |
| P311-01 | 成功したナイロンカエル (@vito233) | Claim comment | 2026-10-16 | 2026-10-21 | #3266 | ✅ PR merged 2026-10-17; contribution complete; further model factory cases available, reservation released |
| P311-09 | Aizen__28 (@Yudeeswaran) | Claim comment | 2026-10-15 | 2026-10-20 | #3239 | ✅ PR merged 2026-10-16; opportunity complete; reservation ended |
| P311-15 | Shivam Maurya (@shivampwm2020) | Claim comment | 2026-10-14 | 2026-10-19 | #3208 | ✅ PR merged 2026-10-14; opportunity complete; reservation ended |
| P311-01 | Kushal Talati (@kushaltalati) | Claim comment | 2026-10-14 | 2026-10-19 | #3201 | ✅ PR merged 2026-10-14; contribution complete; further model factory cases available, reservation released |
| P311-09 | Aizen__28 (@Yudeeswaran) | Claim comment | 2026-10-14 | 2026-10-19 | #3205 | ✅ PR merged 2026-10-14; contribution complete; initialization timeout investigation available, reservation released |
| P311-01 | Kushal Talati (@kushaltalati) | Claim comment | 2026-10-13 | 2026-10-18 | #3194 | ✅ PR merged 2026-10-14; contribution complete; remaining cases available, reservation released |
| P311-08 | Aizen__28 (@Yudeeswaran) | Claim comment | 2026-10-13 | 2026-10-18 | #3175 | ✅ PR merged 2026-10-13; contribution complete; remaining cases available, reservation released |
| P311-16 | Kushal Talati (@kushaltalati) | Claim comment | 2026-10-13 | 2026-10-18 | #3176 | ✅ PR merged 2026-10-13; opportunity complete; reservation ended |
| P311-04 | Roman Lutz (@romanlutz) | Historical PR, opened before this issue; no claim | N/A | N/A | #3064 | ✅ PR merged; prior art covers part of the opportunity; remaining cases available |
Describe alternatives you've considered, if relevant
Keep existing implementations when they already express the required behavior clearly. Avoid a repo-wide modernization sweep: each contributor investigates and opens a focused PR for ONE opportunity at a time. Separate changes within an item should remain cohesive; coordinate here before splitting or expanding scope.
Additional context
- Python 3.11 release notes
- Article motivating this inventory
- Existing adoption includes
datetime.UTC,Self,NotRequired, genericTypedDict,StrEnum,TaskGroup, timeouts, exception groups, and SQLite extended error codes. - Better traceback locations and interpreter improvements arrive automatically on 3.11+; they do not need modernization PRs, and model-call performance is often network-bound.
typing.override,typing.TypeAliasType, thetype Alias = ...statement, andclass Foo[T]syntax are 3.12+, not 3.11. Keep neededtyping_extensionsimports while supporting 3.11.- Other 3.11 APIs such as
dataclass_transformcan be considered when there is a concrete fitting abstraction, but should not motivate new abstractions on their own.
Activity
romanlutz commentedon Oct 13, 2026
Roman Lutz (@romanlutz): P311-04 has related work in #3064, which opened on 2026-10-09 at 22:00:12 UTC, before this tracking issue existed, and merged on 2026-10-13 at 07:06:53 UTC. There was no prior claim here, so this is historical overlap, not a contributor bypassing the new claim rule.
That PR adds
assert_typechecks for retry helpers and async task return types, and brings the unit tests into themake tycheck. It partially addresses the type-regression opportunity. I am linking it as prior art but leaving P311-04 unchecked and available pending your assessment of the remaining scope. No duplicate claim exists and no new assignment is needed for the already-merged PR.Yudeeswaran commentedon Oct 13, 2026
Claiming P311-08 (
BaseException.add_note).I’ll investigate dataset-fetch failure propagation in
SeedDatasetProvider.fetch_datasets_async(pyrit/datasets/seed_datasets/seed_dataset_provider.py). Providers are fetched concurrently, and a failing provider’s exception may propagate without identifying the dataset (e.g., “SeedDataset cannot be empty”).I plan to add diagnostic context using
add_note(), including the dataset name and provider class, while preserving the original exception type and traceback.I’ll add a regression test to verify that the original exception is preserved and that the diagnostic note contains the expected dataset and provider information, without exposing prompt content or other sensitive data.
romanlutz commentedon Oct 13, 2026
Assigning P311-08 to you Aizen__28 (@Yudeeswaran).
kushaltalati commentedon Oct 13, 2026
Claiming P311-16 (Simplify ISO timestamp parsing).
I'll remove the .replace("Z", "+00:00") workaround in _parse_datetime since Python 3.11 handles it natively. Historical Alembic revisions will remain untouched. I'll preserve timezone and accepted-input contracts and update test coverage.
romanlutz commentedon Oct 13, 2026
Assigning P311-16 to you Kushal Talati (@kushaltalati). Linked #3176 and Aizen__28 (@Yudeeswaran)'s #3175 in the table.
romanlutz commentedon Oct 13, 2026
Post-merge assessment for P311-08: #3175 is merged and successfully covers dataset/provider context on concurrent dataset-fetch failures. Thank you Aizen__28 (@Yudeeswaran); your contribution is complete and your reservation is released, so you may claim another opportunity.
The broader exception-note opportunity remains unchecked and available. I assessed the merged diff and current main at
20b35221c514b7f0898caac12f14b71631889027and added two concrete follow-up cases to the checklist:Scenario._run_atomic_attacks_parallel_async: caught errors are stored without their atomic-attack association before aggregation. Safe scenario/atomic-group notes could identify which concurrent operation failed without logging seed text.close_services_async: exception notes could identify which close operation produced each grouped shutdown error.These are focused investigations, not instructions to annotate every exception. Preserve cancellation, exception identities/types, group contracts, and sensitive-data boundaries. Claim exactly one opportunity on this thread before starting.
kushaltalati commentedon Oct 13, 2026
PR #3176 is approved with all CI checks passing. Once merged, I would like to claim P311-01 (Extend typing.Self adoption).
I plan to investigate adopting typing.Self across classmethod factories and fluent methods (such as YamlLoadable.from_yaml_file and Seed.from_yaml_file) while preserving independent generic parameters.
romanlutz commentedon Oct 13, 2026
P311-16 is complete with #3176. No other active ISO-parsing workarounds remain; the historical migration stays unchanged. Assigning P311-01 to you Kushal Talati (@kushaltalati) now that #3176 is merged.
29 remaining items
romanlutz commentedon Oct 17, 2026
P311-09 is complete with #3239 merged. The initialization and Copilot receive loops now have shared budgets, and no further shared-budget migration is needed among the current timeout sites. Thanks Aizen__28 (@Yudeeswaran)! Your reservation is released.
romanlutz commentedon Oct 17, 2026
Thanks 成功したナイロンカエル (@vito233)! #3266 is merged, and your reservation is released. P311-01 stays open:
MessagePiece.adversarial_placeholderand the twoAttackTechniqueSeedGroupfactories still construct throughclsbut return the concrete base type in their annotations. The checklist now points to these remaining cases. Please claim one focused factory family here before starting.romanlutz commentedon Oct 17, 2026
Thanks Slai.life (@huong8373tt-beep)! #3277 is merged, and your reservation is released. P311-08 remains available for the service-shutdown context case now listed in the checklist.
huong8373tt-beep commentedon Oct 17, 2026
Claiming the remaining P311-08 service-shutdown context case. I will add safe operation-name notes for failures collected by close_services_async, preserving exception identity/type/tracebacks, cancellation behavior, and BaseExceptionGroup behavior, with focused lifecycle regression coverage. I am proceeding directly with the investigation and implementation.
romanlutz commentedon Oct 17, 2026
Assigning P311-08 to you Slai.life (@huong8373tt-beep). Linked #3281 in the table.
romanlutz commentedon Oct 19, 2026
Thanks Slai.life (@huong8373tt-beep)! #3281 is merged, and your reservation is released. P311-08 stays open for the focused runtime-shutdown phase-context investigation now listed in the checklist.
huong8373tt-beep commentedon Oct 19, 2026
Claiming the remaining focused P311-08 runtime-shutdown phase-context investigation.
I will investigate
RuntimeLifecycle._shutdown_runtime_asyncand add only safe static phase-name notes for the currently unlabelled scenario-service shutdown and memory-disposal failures. I will preserve exception identity, type, tracebacks, existing notes, cleanup order, cancellation behavior, and the existing single/grouped failure shape; I will not duplicate the service-close context from #3281 or include prompts, seeds, or secrets. I will add focused regression coverage intests/unit/backend/test_runtime_lifecycle.py.I will wait for confirmation before treating this item as reserved.
huong8373tt-beep commentedon Oct 19, 2026
Clarification: I am proceeding with the focused investigation and implementation now under this single P311-08 claim; the earlier wording only meant I would not assume assignment status beyond the claim. I will keep the scope limited to
RuntimeLifecycle._shutdown_runtime_asyncand open the focused PR within the stated deadline.romanlutz commentedon Oct 19, 2026
Assigning P311-08 to you Slai.life (@huong8373tt-beep). Linked #3333 in the table. Your PR was opened within the five-day deadline, so the runtime-shutdown phase-context scope stays reserved while it is open.