Repository navigation
FIX: run only the Psychosocial sub-harms whose datasets were picked - #3086
Merged
Richard Lundeen (richlundeen) merged 5 commits intoOct 12, 2026
Merged
Richard Lundeen (richlundeen) merged 5 commits into
Richard Lundeen (richlundeen) merged 5 commits into
Conversation
Richard Lundeen (richlundeen)
approved these changes
Oct 11, 2026
Richard Lundeen (richlundeen)
enabled auto-merge
October 11, 2026 22:55
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3dac88b3-ab21-4741-9ee9-beb49a3adeea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3085.
_selected_sub_harms()now keeps only the requested sub-harms whose dataset is in the dataset config. Validation, seed resolution, the estimate and the attack build all go through it, so a dataset subset narrows all of them. If none of the requested sub-harms has its dataset, it raises aDatasetConstraintErrorthat names the missing dataset.The default config has both datasets, so default runs and
sub_harmalone behave the same as before. Compound configs still hit the existing "compound children" error.Same repro on this branch:
Tests: a therapist-only config builds and estimates only that sub-harm, and sub_harm=imminent_crisis with only the therapist dataset raises. Both fail on main. tests/unit/scenario and backend: 3815 passed.