Use shellcheck-py for shellcheck pre-commit hook - #8547
Merged
Merged
Conversation
The jumanjihouse shellcheck hook requires a system shellcheck binary and does not work on Windows. shellcheck-py ships wheels for all platforms, so the hook now runs everywhere. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jens Hedegaard Nielsen (jenshnielsen)
requested a review
from a team
as a code owner
September 29, 2026 07:38
Jens Hedegaard Nielsen (jenshnielsen)
enabled auto-merge
September 29, 2026 07:38
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8547 +/- ##
==========================================
- Coverage 72.28% 72.19% -0.09%
==========================================
Files 307 307
Lines 32424 32322 -102
==========================================
- Hits 23438 23336 -102
Misses 8986 8986 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Cina Arjmand (CinaArjmand)
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jumanjihouse shellcheck hook requires a system shellcheck binary and does not work on Windows. shellcheck-py ships wheels for all platforms, so the hook now runs everywhere.