Skip to content

fix(native-core): silence unused block parameter warnings in macOS FocusZone #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Saad Najmi (Saadnajmi) wants to merge 1 commit into from
Closed

fix(native-core): silence unused block parameter warnings in macOS FocusZone #4365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/native-core-focuszone-unused-params.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@fluentui-react-native/native-core": patch
---

Mark the unused block parameters in the macOS FocusZone traversal as `__unused` so the file compiles cleanly with `-Wunused-parameter` treated as an error.
2 changes: 1 addition & 1 deletion packages/agentic/native-core/macos/components/FocusZone/shared/RCTFocusZone.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ - (NSView *)nextViewToFocusInHierarchyForAction:(FocusZoneAction)action
AppendFocusableViewsWithin(self, focusableViews);

NSView *firstResponder = GetFirstResponder([self window]);
NSUInteger currentIndex = [focusableViews indexOfObjectPassingTest:^BOOL(NSView *candidateView, NSUInteger index, BOOL *stop) {
NSUInteger currentIndex = [focusableViews indexOfObjectPassingTest:^BOOL(NSView *candidateView, __unused NSUInteger index, __unused BOOL *stop) {
return candidateView == firstResponder
|| [candidateView isDescendantOf:firstResponder]
|| [firstResponder isDescendantOf:candidateView];
Expand Down
Loading