Repository navigation
Reorganize agent instructions into shared references and component workflow skills - #4371
Merged
Merged
Conversation
Move reusable agent guidance into references/agents with a documented taxonomy, standardized frontmatter, rule IDs, and compatibility redirects. Add maintain-v0-v1-component, review-component, and implement-native-component skills; slim root AGENTS.md to safeguards and routing; extract permissions with sentence-level parity; and add sanitized evaluation case fixtures. Add `yarn check-agent-instructions`, a deterministic integrity checker with node tests, and run it in `yarn lage buildci` and `repo-checks`. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move the Apple native authoring and Office integration rules into references/agents/native/apple-office.md as R-APPLE-001 to R-APPLE-007, with sentence-level parity, and route the root safeguards, implement-native-component, and review-component to them. Add Apple implementation, review, and holdout evaluation cases. Add R-VALID-003: finish code, configuration, and instruction changes with one `yarn lage buildci --no-cache` run so stale Lage cache entries cannot hide failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Extend `yarn check-agent-instructions` to build the explicit prerequisite graph and reject cycles or chains deeper than three reads, keep compatibility references terminal, require routing tables to send each task to exactly one skill consistently across routers, and require every skill to be routed from the root AGENTS.md. Document the conventions in references/agents/README.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GPT-6.1 Sol development probes followed the root routing row for "plan-only" agentic work into contract authoring and skipped the authoring workflow and its types-and-slots recipe. Route plans to change an agentic component through the authoring skill, which applies the contract gate, and reserve the contract skill for contract-only or contract-feasibility work. Link the Flex token map from the contract workflow and Flex adapter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove completed work from agent-improvements-plan.md. Record the independently scored GPT-6.1 Sol pilot alongside the earlier Claude Sonnet results, and list the open decisions: version-bound evidence, skill size, redirect retirement, stale contributor docs, holdout-derived refinements, evidence sufficiency, and validation after an aborted uncached run. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a root `yarn clean-lage-cache` script (`lage cache --clear`) and change R-VALID-003 to clear the Lage cache before the final `yarn lage buildci`. `--no-cache` bypasses the cache for one run but leaves earlier entries, so a cached rerun after an aborted uncached run could reuse results for tasks that never executed. After clearing, a plain rerun executes every task that has not passed. Remove the resolved R07 decision from the plan. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Move version-bound focus and accessibility observations into evidence-reference documents (C-FOCUS-*, C-A11Y-*) and cite them from the rules and component accessibility specs. - Split fix-security-issues into a 371-word workflow and a dependency security procedure reference, preserving every sentence. - Remove the 16 compatibility redirects; keep redirects only for known external links. - Fix stale FluentTester and E2E paths in contributor documentation. - Route native-core legacy wrappers away from v0/v1 maintenance, read native-core documents only for native-core work, and validate iOS through its host app. Relabel the two informed holdouts and add two new ones. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update CONTRIBUTING.md so new components use packages/agentic/components, describe the contract, source layout, tests, and final validation, keep v0 and v1 FluentTester/E2E guidance for maintenance, and send new native code to native-core. Remove the completed agent-improvements-plan.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Jason Morse (JasonVMo)
enabled auto-merge (squash)
October 15, 2026 07:18
CodeQL flagged the one-pass `<[^>]+>` replacement in the agent-instruction checker's slug helper as incomplete multi-character sanitization. Remove inline tags with a scanner that tracks nesting, and cover nested markup in the slug test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Anandraj (mganandraj)
approved these changes
Oct 15, 2026
Saad Najmi (Saadnajmi)
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
No runtime platform code changes. This PR changes agent instructions, skills, contributor documentation, and repository validation tooling.
Description of changes
Reorganizes repository agent guidance so shared knowledge lives in one place and loads only when a task needs it. Adds clearer workflows for v0/v1, agentic, native, and review work, and lays groundwork for future agent evaluations.
Shared references (
references/agents/)id,kind,owner_paths). Documents useR-*rule IDs for testable obligations andC-*claim IDs for version-bound evidence.evidence-referencedocuments:focus/platform-evidence.mdandaccessibility/action-transport-evidence.md. The rules, and three component accessibility specs, cite them.Skills (
.github/skills/)maintain-v0-v1-component,review-component(read-only, covers all generations), andimplement-native-component(also provides a native overlay checklist).fix-security-issuesis split into a 371-word workflow plus a procedure reference, with every rule preserved.Root and scoped instructions
AGENTS.mdshrinks from 27.4 KB to 8.0 KB. It keeps always-on safeguards (permissions, validation truthfulness, code rules, generation policy, native trigger), a task routing table, and a scoped-instruction index. Copilot CLI loads root content twice through theCLAUDE.mdimport.AGENTS.mdfiles become short maintainer routes. Stale commands and paths were corrected.packages/agentic/components; v0 and v1 are maintenance-only.Tooling
yarn check-agent-instructionsis a deterministic checker that runs inyarn lage buildciandrepo-checks. It validates:@fluentui-react-native/scripts.yarn clean-lage-cache(lage cache --clear). Final validation is nowyarn clean-lage-cachefollowed byyarn lage buildci.Evaluation groundwork
references/agents/evals/cases/(10 development, 5 holdout), with a documented local result-record shape. No evaluation framework is committed. The efficiency or efficacy skill intentionally stays outside this repository.Contributor documentation
CONTRIBUTING.mdnow directs new components to the agentic package and keeps v0/v1 FluentTester/E2E guidance for maintenance.CONTRIBUTING.mdandapps/E2E/README.md.Verification
Automated:
yarn clean-lage-cachethenyarn lage buildci --groupedyarn check-agent-instructionsyarn workspace @fluentui-react-native/scripts testyarn lage test-links --groupedyarn change:checkyarn test:agent-permissionsyarn workspace @fluentui-react-native/components check:spec-contractsAgent routing pilot: read-only Copilot CLI 1.0.98 probes, one run per case, comparing the pre-change instructions with this branch.
Refinements informed by holdouts were rechecked. Those cases were relabeled as development and replaced with new holdouts.
Pull request checklist
This PR has considered (when applicable):
Keyboard, VoiceOver, and RTL behavior are not affected; no component runtime code changed.