feat(react-charts): support custom GaugeChart callouts - #36730
Draft
Atishay Jain (atisjai) (AtishayMsft) wants to merge 3 commits into
Draft
feat(react-charts): support custom GaugeChart callouts#36730Atishay Jain (atisjai) (AtishayMsft) wants to merge 3 commits into
Atishay Jain (atisjai) (AtishayMsft) wants to merge 3 commits into
Conversation
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
Contributor
Author
|
[ReviewAgent] Concern: the description is still the blank template - no previous/new behavior, no linked issue, no screenshot of a custom gauge callout. fill it in so reviewers can judge whether this is the api shape we want. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Menu 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu.Nested Submenus Small Viewport Flipped.nested menu.chromium.png | 718 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 627 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 603 | Changed |
vr-tests-react-components/ProgressBar converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 50 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 78 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 66 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png | 635 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
GaugeChartalways rendered its built-in callout content. Consumers could style the popover, but could not replace or wrap its content, add domain-specific units, or identify which gauge segment opened the callout.New Behavior
onRenderCalloutfor replacing or wrapping the default GaugeChart callout.GaugeChartCalloutDatawith the active legend, chart value, effective minimum and maximum, formatted value, and visible segment values.defaultRenderso custom content can compose with the standard callout.GaugeChartCustomCalloutStorybook example demonstrating temperature units.Preview
Open the PR demo site and select Charts / GaugeChart / Gauge Chart Custom Callout.
Validation
yarn nx run react-charts:test --testPathPatterns=GaugeChart.test.tsx --runInBandyarn nx run react-charts:lintyarn nx run react-charts-stories:lintRelated Issue(s)
No linked issue; this API addition follows consumer feedback requesting customizable GaugeChart callouts and support for non-percentage units.