Skip to content

Fix bundled editor CSS package export - #5459

Open
dawn (dawNotPoi) wants to merge 1 commit into
microsoft:mainfrom
dawNotPoi:fix/5404-export-editor-css
Open

Fix bundled editor CSS package export#5459
dawn (dawNotPoi) wants to merge 1 commit into
microsoft:mainfrom
dawNotPoi:fix/5404-export-editor-css

Conversation

@dawNotPoi

Copy link
Copy Markdown

Summary

  • export the existing bundled editor stylesheet through the package exports map
  • add an esbuild smoke regression that resolves the CSS from the generated package

Tests

  • npm run build-lsp
  • npm run build-monaco-editor
  • npm test
  • npm run compile --prefix webpack-plugin
  • npm run package-for-smoketest
  • npx prettier --check package.json test/smoke/package-esbuild.ts test/smoke/esbuild/editor-main-css.js

Fixes #5404

@dawNotPoi

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Unable to import "monaco-editor/min/vs/editor/editor.main.css"

1 participant