Resolve pyright and Ruff failures + Update stubtest TODOs

.github/workflows/test.yml

@@ -36,7 +36,7 @@ jobs:
         run: python -m pip install --group tests
 
       - name: Run pyright tests
-        uses: jakebailey/pyright-action@v2
+        uses: jakebailey/pyright-action@v3
         with:
           pylance-version: latest-prerelease
           python-version: ${{ matrix.python-version }}
@@ -56,6 +56,6 @@ jobs:
         uses: actions/checkout@v2
 
       - name: Run Ruff Linter
-        uses: astral-sh/ruff-action@v3
+        uses: astral-sh/ruff-action@v4.1.0
       - name: Run Ruff Formatter
         run: ruff format --check

.gitignore

@@ -359,6 +359,7 @@ MigrationBackup/
 
 # Lock files (like uv.lock)
 *.lock
+.python-version
 
 # Build files from utils
 .eggs

.vscode/extensions.json

@@ -2,8 +2,7 @@
     // See https://go.microsoft.com/fwlink/?LinkId=827846
     // for the documentation about the extensions.json format
     "recommendations": [
-        "ms-python.black-formatter",
-        "ms-python.isort",
+        "charliermarsh.ruff",
         "ms-python.mypy-type-checker",
         "ms-python.python",
         "ms-python.vscode-pylance",

pyproject.toml

@@ -25,7 +25,7 @@ tests = [
 
     # The libraries we're stubbing.
     # Needed for stubtest and downloads their dependencies to get known import symbols
-    "scikit-image",
+    "scikit-image <0.26.0", # TODO: skimage 0.26 doesn't support Python 3.10, which we do
     "scikit-learn <1.7.0", # TODO: Update stubs for sklearn
     "sympy",
     "vispy",
@@ -168,15 +168,14 @@ disable_error_code = [
     # Incompatible overrides are out of our stubs' control
     # as they are inherited from the implementation.
     "override",
-    # TODO
-    "assignment", # 688 errors in 155 files
 ]
 
 [[tool.mypy.overrides]]
 module = ["sympy.*"]
 disable_error_code = [
     # TODO
     "misc", # 185
+    "assignment", # 611 errors in 134 files
 ]
 
 [[tool.mypy.overrides]]
@@ -185,11 +184,12 @@ module = ["matplotlib.*"]
 disable_error_code = ["assignment", "misc", "untyped-decorator"]
 
 [[tool.mypy.overrides]]
-module = ["sklearn.*"]
+module = ["sklearn.*", "preprocessing_tests"]
 disable_error_code = [
     # TODO
     "misc", # 25
     "overload-overlap", # 14
+    "assignment", # 52
 ]
 
 [[tool.mypy.overrides]]
@@ -198,3 +198,10 @@ disable_error_code = [
     # TODO: Too many untyped decorators still left
     "untyped-decorator", # 52
 ]
+
+[[tool.mypy.overrides]]
+module = ["vispy.*"]
+disable_error_code = [
+    # TODO
+    "assignment", # 25
+]

stubs/matplotlib/pyplot.pyi

@@ -779,7 +779,7 @@ def tick_params(axis: Literal["x", "y", "both"] = ..., **kwargs): ...
 def ticklabel_format(
     *,
     axis: Literal["x", "y", "both"] = ...,
-    style: Literal["sci", "scientific", "plain"] = ...,  # noqa: F811
+    style: Literal["sci", "scientific", "plain"] = ...,
     scilimits=...,
     useOffset: bool | float = ...,
     useLocale: bool = ...,