-
Notifications
You must be signed in to change notification settings - Fork 104
Resolve F401 TODO for __init__.pyi
#400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,10 +2,10 @@ import contextlib | |
| from collections.abc import Generator | ||
| from typing import Literal | ||
|
|
||
| import numpy as np | ||
| from packaging.version import parse as parse_version | ||
| from matplotlib import ( | ||
| colors as colors, # Example usage: https://matplotlib.org/stable/users/explain/colors/colormapnorms.html#colormap-normalization | ||
| ) | ||
|
|
||
| from . import _docstring, _version, cbook, colors as colors, rcsetup | ||
| from ._typing import * | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Could you confirm that
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Kept import matplotlib as mpl
norm = mpl.colors.Normalize(vmin=-1, vmax=1)But even matplotlib's own pyi (as of 3.8.0+, these stubs are explictly for 3.7.5) shows these were not meant for explicit re-export: |
||
|
|
||
| class __getattr__: | ||
|
|
||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| from pathlib import Path | ||
|
|
||
| from sympy.utilities.decorator import doctest_depends_on | ||
|
|
||
| __doctest_requires__ = ... | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📍 stubs/matplotlib/init.pyi:5
The prior export-parity concern is only partially addressed:
colorsis restored, but normal package-level access tomatplotlib.cbookandmatplotlib.rcsetupremains untyped. Verify those runtime attributes and restore their explicit re-exports when supported, with regression coverage for package-qualified access.[verified]