Restore running tests on Python 3.9 (oldest supported Python version) - #402
Open
Avasam (Avasam) wants to merge 1 commit into
Conversation
Avasam (Avasam)
force-pushed
the
Restore-running-tests-on-Python-3.9-oldest-supported-Python-version
branch
from
September 21, 2026 19:55
af4f91f to
51e5258
Compare
Member
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
Member
|
Result: Verification detailsVerification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Summary: The sandbox only provided Python 3.13, and offline dependency setup was blocked by a missing `docopt-ng` wheel, so the Python 3.9 CI matrix could not be exercised. An ad-hoc check confirmed the dependency marker, workflow fallback, and both `run_tests.py` version branches. A mypy control passed, but the available unpinned mypy 2.3.1 cannot target Python 3.9. No tests were added for the new installer branch. Test runs: 3 passed, 4 not run
|
Bill Schnurr (bschnurr)
approved these changes
Sep 21, 2026
Bill Schnurr (bschnurr)
left a comment
Member
There was a problem hiding this comment.
Approved via Review Center.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title says.
Done by force-installing a compatible-enough version of
scipy-stubs. Conditions should make it easy to grep and remove once Python 3.9 support is dropped from PyLance stubs.As other PRs, requires #397 first.
Alternatively, if maintainers make the call that 3.9 is no longer supported (due to being EOL, even 3.10 is EOL soon !), then I'll close this PR in favor of bumping the min-supported version in configs.