Repository navigation
fix(macos): keep the view's shadow color alive - #3129
Draft
Saad Najmi (Saadnajmi) wants to merge 1 commit into
Draft
Saad Najmi (Saadnajmi) wants to merge 1 commit into
Saad Najmi (Saadnajmi) wants to merge 1 commit into
Conversation
On macOS, RCTView declares shadowColor as an assign CGColorRef property, so it kept the color it was given without retaining it. That color is autoreleased, so by the time didUpdateShadow read it, it could already be freed, which crashed. Convert the color to an NSColor as soon as it's set, and keep that instead. Setting it to NULL clears the color. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 33ac4470-c1d2-43c0-92ee-8407909f0f6a
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On macOS,
RCTViewdeclaresshadowColoras anassignCGColorRefproperty, sosetShadowColor:stored the color without retaining it.+[RCTConvert CGColor:]returns theCGColorof an autoreleasedNSColor(it'sCF_RETURNS_NOT_RETAINED), so the color could be freed by the timedidUpdateShadowread it again, for example whenshadowOpacityorshadowRadiuswas set afterwards. That crashed.This converts the color to an
NSColorwhen it's set and keeps that instead. Setting the color toNULLnow clears it.Office shipped this fix (without the
NULLhandling) in its copy of React Native macOS 0.81.Test Plan:
Built the same change on 0.81 in Office for macOS arm64 and x86_64, with warnings as errors. CI covers
main.