Repository navigation
Warm the CLI-init app closure in warm-feed - #16458
Merged
Vladimir Morozov (vmoroz) merged 1 commit intoSep 26, 2026
Merged
Vladimir Morozov (vmoroz) merged 1 commit into
Vladimir Morozov (vmoroz) merged 1 commit into
Conversation
Copilot started reviewing on behalf of
Vladimir Morozov (vmoroz)
September 26, 2026 00:19
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the CLI-init scripts and includes focused coverage for the new behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Extends warm-feed coverage to CLI-created apps and prevents nightly library scaffolding failures.
Changes:
- Adds and registers app dependency-closure warming across supported branches.
- Uses stable base versions when scaffolding nightly libraries.
- Adds unit tests and documentation.
| File | Description |
|---|---|
warm-feed.config.json |
Enables app closure warming. |
createReactNativeLibrary.test.ts |
Tests nightly scaffold versions. |
createReactNativeApp.test.ts |
Tests app configuration and dependencies. |
specialModules/index.ts |
Registers the app module. |
createReactNativeLibrary.ts |
Uses stable bases for nightly scaffolds. |
createReactNativeApp.ts |
Implements app closure collection. |
README.md |
Documents app warming behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vladimir Morozov (vmoroz)
enabled auto-merge (squash)
September 26, 2026 17:10
Khalef Hosany (Khalef1)
approved these changes
Sep 26, 2026
Vladimir Morozov (vmoroz)
deleted the
PR/handle-cli-apps-in-warm-feed
branch
September 26, 2026 23:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
The CLI-init tests scaffold a fresh project and install it anonymously from the
isolated
ms/react-native-publicfeed, which only serves a version once anauthenticated identity has pulled it. warm-feed already reproduces the library-init
closure but not the app-init closure, so new app-template dependencies were never
warmed — anonymous PR builds then failed to restore them (e.g. the CLI checks on
#16449 and #16447 could not
download
react-native-safe-area-context@5.10.0, which had to be warmed by hand).Separately, the scheduled warm-feed run itself went red: the existing library scaffold
resolves a nightly React Native through the short-lived
@react-native-community/template@nightlytag, and once that tag rotated away thescaffold failed with
ETARGET.What
Warm the CLI-init app closure. A new
create-react-native-appwarm-feed modulereproduces
creaternwapp.cmd's scaffold for each release branch and warms the generatedapp's dependency graph (e.g.
react-native-safe-area-context), which feed enumerationcan't discover on its own. It's enabled across
mainand the stable branches, so thescheduled run keeps that closure warm and isolated PR builds restore it anonymously. It
mirrors the app script's template selection, including the fixed stable template used
when React Native is a nightly.
Fix nightly library scaffolding. The existing
create-react-native-librarymodulescaffolded a nightly React Native via the short-lived
@react-native-community/template@nightlytag, which rotates away and then fails(
ETARGET), turning the scheduled run red. It now scaffolds from the matching stablebase version (
0.87.0-nightly-…→0.87.0) and rewrites the generated closure back tothe nightly, mirroring the same workaround already in
creaternwlib.cmd.Testing
Exercised through the scheduled warm-feed pipeline — the run is green. Unit tests cover
the new module's config/version/template selection and the nightly scaffold-version
helper.
Changelog
Should this change be included in the release notes: no
Internal feed-warming tooling now covers the CLI-init app closure and no longer breaks on
nightly templates; no user-facing change.
Microsoft Reviewers: Open in CodeFlow