Skip to content

Unblock C# data-plane upgrade PRs on management approval mismatches - #12193

Draft
Jorge Rangel (jorgerangel-msft) with Copilot wants to merge 7 commits into
mainfrom
copilot/bug-fix-management-emitter-blocks-csharp-upgrades
Draft

Jorge Rangel (jorgerangel-msft) with Copilot wants to merge 7 commits into
mainfrom
copilot/bug-fix-management-emitter-blocks-csharp-upgrades

Conversation

Copilot AI commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Dashboard regeneration validates management dependencies even during independent data-plane upgrades, aborting PR submission on unrelated approval mismatches.

  • Approval isolation: Allow data-plane PR submission to continue after dashboard failures. Keep failures blocking management PR submission without advancing unapproved dependencies.
  • Failure reporting: Report automated submission failures as warnings / SucceededWithIssues, preserving actionable error details and cleanup. Keep manual-run failures fatal.
  • Error handling: Capture dashboard exceptions, nonterminating errors, and nonzero exit codes; restore the caller’s error preference.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Oct 14, 2026
Copilot AI changed the title [WIP] Fix management emitter approval validation for data-plane upgrades Unblock C# data-plane upgrade PRs on management approval mismatches Oct 14, 2026
@pkg-pr-new

pkg-pr-new Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-csharp@12193

commit: 46be8d3

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Changed protected dependencies can bypass approval checks, and handled dashboard lookup failures can incorrectly block management submissions.

2 open findings
What changed in this PR

Updates C# SDK upgrade automation to let data-plane PRs proceed despite unrelated dashboard approval failures.

Changes:

  • Catches dashboard errors and restores the caller’s error preference.
  • Keeps dashboard failures blocking management submissions.
  • Reports automated submission failures as warnings while retaining fatal manual-run behavior.
File Description
packages/​http-client-csharp/​eng/​scripts/​Submit-AzureSdkForNetPr.ps1 Adds dashboard failure isolation and warning-only automated failure reporting.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/http-client-csharp/eng/scripts/Submit-AzureSdkForNetPr.ps1 Outdated
Comment thread packages/http-client-csharp/eng/scripts/Submit-AzureSdkForNetPr.ps1 Outdated
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Approval validation parses a local package reference as a semantic version, still blocking otherwise valid data-plane submissions.

1 open finding
2 resolved since last review

🧠 Review effort: Balanced

Comment thread packages/http-client-csharp/eng/scripts/Submit-AzureSdkForNetPr.ps1 Outdated
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
} catch {
Write-Error "Error creating PR: $_"
exit 1
if ($FailOnError) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot why do we need this ? Shouldn't the try catch around the emitter version dashboard script allow us to avoid doing this at the end of the outer script ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inner catch only handles dashboard-generation errors. The outer catch covers failures elsewhere in PR submission (for example, commit, push, or gh pr create) and preserves automated-run SucceededWithIssues versus manual-run failure behavior. Dashboard errors caught by the inner handler never reach the outer catch.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot right, so why are we touching the out catch ? The outer catch works today and shouldn't be touched. The inner catch is the only thing we should be editing. Help me understand otherwise.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot where are we on this ?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Management emitter approval validation blocks C# data-plane upgrade PRs

3 participants