Repository navigation
Unblock C# data-plane upgrade PRs on management approval mismatches - #12193
Jorge Rangel (jorgerangel-msft) with Copilot wants to merge 7 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
commit: |
There was a problem hiding this comment.
🟡 Changes recommended
Changed protected dependencies can bypass approval checks, and handled dashboard lookup failures can incorrectly block management submissions.
2 open findings
What changed in this PR
Updates C# SDK upgrade automation to let data-plane PRs proceed despite unrelated dashboard approval failures.
Changes:
- Catches dashboard errors and restores the caller’s error preference.
- Keeps dashboard failures blocking management submissions.
- Reports automated submission failures as warnings while retaining fatal manual-run behavior.
| File | Description |
|---|---|
| packages/http-client-csharp/eng/scripts/Submit-AzureSdkForNetPr.ps1 | Adds dashboard failure isolation and warning-only automated failure reporting. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>
| } catch { | ||
| Write-Error "Error creating PR: $_" | ||
| exit 1 | ||
| if ($FailOnError) { |
There was a problem hiding this comment.
Copilot why do we need this ? Shouldn't the try catch around the emitter version dashboard script allow us to avoid doing this at the end of the outer script ?
There was a problem hiding this comment.
The inner catch only handles dashboard-generation errors. The outer catch covers failures elsewhere in PR submission (for example, commit, push, or gh pr create) and preserves automated-run SucceededWithIssues versus manual-run failure behavior. Dashboard errors caught by the inner handler never reach the outer catch.
There was a problem hiding this comment.
Copilot right, so why are we touching the out catch ? The outer catch works today and shouldn't be touched. The inner catch is the only thing we should be editing. Help me understand otherwise.


Dashboard regeneration validates management dependencies even during independent data-plane upgrades, aborting PR submission on unrelated approval mismatches.
SucceededWithIssues, preserving actionable error details and cleanup. Keep manual-run failures fatal.