Fix: Handle quantifiers and staticness properly when resolving Mixin target methods. - #2645
Merged
Earthcomputer merged 1 commit intoSep 20, 2026
Conversation
LlamaLad7
force-pushed
the
fix/target-selector-behaviours
branch
2 times, most recently
from
September 20, 2026 16:00
40a7b6f to
0ac7c12
Compare
Contributor
Author
|
Test failure seems to be a flake |
LlamaLad7
force-pushed
the
fix/target-selector-behaviours
branch
from
September 20, 2026 16:10
0ac7c12 to
84b6753
Compare
Earthcomputer
left a comment
Earthcomputer
left a comment
Member
There was a problem hiding this comment.
Should probably also check handler.canAlwaysBeStatic
…target methods. We should only take as many matches as is allowed, and additionally static methods should not be considered unless our handler is also static or we are trying to select exactly 1 method.
LlamaLad7
force-pushed
the
fix/target-selector-behaviours
branch
from
September 20, 2026 20:13
84b6753 to
f494bde
Compare
Contributor
Author
Not sure what you mean by this |
Member
|
There's a method in |
Contributor
Author
|
I'm aware, but Mixin does not account for that when selecting target methods. The incorrect staticness will be flagged later by the relevant inspection (matching the error that will occur at runtime) |
Earthcomputer
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should only take as many matches as is allowed, and additionally static methods should not be considered unless our handler is also static or we are trying to select exactly 1 method.