Skip to content

Select with Tab Key #85

Open
Open

Description

@sweeperq

Love the graphical aspect of the toggles. However, it seems that the toggles are no longer selectable via a Tab press. It's not just that the order of tabindex is messed up; you can't even get to them without a pointing device.

Activity

  1. JamieReid77 commented on Mar 18, 2016

    @JamieReid77

    $toggleHandle at line 55 needs to be a <button>, not a <span>.

    Pull request #107 attempts to resolve this, however it fails when a tabindex is manually declared on elements as the tabindex is not passed through to $toggleHandle.

    I'm going to create a new pull request that resolves this shortly.

  2. Nfinished commented on Apr 25, 2016

    @Nfinished

    @jamiedavidreid eta? I'm working on aria support and I'd like to include your changes.

  3. pvagner commented on Jul 7, 2016

    @pvagner

    @cafune Are you still working on this or do you know if there is a way on how to make toggles this component produces better accessible with assistive technologies - screen readers?

  4. Nfinished commented on Jul 7, 2016

    @Nfinished

    @pvagner I switched to using this library rather than trying to jury rig this one.

  5. nelson6e65 commented on Feb 14, 2017

    @nelson6e65

    I solved by modifying and adding listener to div.toggle:

    $(function() {
      var $elements;
      $elements = $("div.toggle");
      if ($elements.length > 0) {
        $elements.attr("tabindex", 0);
        $elements.keydown(function(event) {
          if (event.keyCode === 32) {
            return $(this).trigger('click');
          }
        });    
      }
    });
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions