Skip to content

Support S2CellIndex #1

Closed
Closed

Description

@benjamin-cooper-ai

Hi! Are there plans to support S2CellIndex in this library? More specifically, would PRs adding it be accepted?

Activity

  1. missinglink commented on Nov 13, 2025

    @missinglink
    Owner

    Hi @benjamin-cooper-ai I'm not planning any additions to the codebase at this point.
    TBH it was a big slog to get this far and I kinda burned out on it.

    That said, I'd be happy to review and merge a PR to add the S2CellIndex functionality.

    The implementation so far was based on the Golang Port as I'm more familiar with Go and found it easier to convert to TS.

    The Go lib at that time (and IIRC still now) doesn't have that functionality, so it would need to be ported from the main CPP codebase you linked.

    I would suggest using some LLMs to help you, but obviously they will need to be managed to avoid making a mess, ideally they can follow the existing conventions and copy the unit tests faithfully from the CPP code to ensure correctness.

  2. missinglink commented on Nov 13, 2025

    @missinglink
    Owner

    Out of curiosity, what is your main use-case for S2CellIndex and do you know which higher level dependants it has which we might be able to implement afterward?

  3. benjamin-cooper-ai commented on Jan 21, 2026

    @benjamin-cooper-ai
    ContributorAuthor

    Hey @missinglink, our use case is basically a frontend figuring out which files (which are named by s2 cell token) it should ask the backend for. We already extensively use the C++ library for this and my experience with using the C++ library in WASM is that you end up writing very painful build files.

    The PR is up and I marked it as ready for review. If you could take a look, that would be great! If it helps, we are using this logic in this PR already. #2

  4. github-actions commented on Jan 26, 2026

    @github-actions

    🎉 This issue has been resolved in version 1.44.0 🎉

    The release is available on:

    Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions