Repository navigation
Conversation
zcbenz
force-pushed
the
graph-leak-check
branch
2 times, most recently
from
October 17, 2026 05:07
36efc70 to
99b0958
Compare
zcbenz
force-pushed
the
graph-leak-check
branch
from
October 17, 2026 07:09
99b0958 to
0a31578
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add debug time check that would throws error when 2 common types of errors are found:
1. Temporary arrays are not registered by
add_temporaryThis is checked by iterating all pointers in the graph and checking whether they are valid allocations, which can capture mistakes like the ones fixed by #4660:
2. Input or outputs arrays are accidentally registered by
add_temporaryThis is checked by simply checking whether the temporaries contain inputs or outputs of a primitive, which can capture mistakes like the ones fixed by #4702: