Skip to content

MAINT: Update dependency specifiers - #14348

Closed
mne-bot wants to merge 1 commit into
mainfrom
spec_zero
Closed

mne-bot wants to merge 1 commit into
mainfrom
spec_zero

Conversation

@mne-bot

@mne-bot mne-bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Created by the spec_zero job of this GitHub Action run.

Adjustments may need to be made to shims in mne/fixes.py and elsewhere in this or another PR. make -C tools/dev dep is a good starting point for finding potential updates.

Comment thread pyproject.toml
# [lock] brings pyodide-lock and uv for jupyter_lite_config.py; pyodide-lock
# needs 3.12, which every docs build has
"jupyterlite-pyodide-kernel[lock] >= 0.8; python_version >= '3.12'",
"jupyterlite-pyodide-kernel >= 0.8[lock]; python_version >= '3.12'",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is getting moved, but it's causing CI failures, so will need to look.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the new renaming code

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is still using the local spec-zero script. I think we just never had a case of a dep with a group having a version specifier

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh okay. Then +1 for fixing it in mne-tools and getting rid of local spec-zero here 😄

Comment thread pyproject.toml
"mne-connectivity",
"mne-gui-addons",
"neo",
"neo", # released 2023-06-30, will become 0.12 on 2028-07-01

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also @thht a bit weird that something we don't pin at all got a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsoner I honestly have no idea what my involvement is here...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh sorry @thht I got my Thomas GitHub names confused because of our recent emails 🤦 😆

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, us Thomasses are everywhere 🤣

@larsoner

Copy link
Copy Markdown
Member

... so I'm going to close this, we shouldn't merge it. Once a PR switches us to mne-tools and the bug is fixed, we workflow-dispatch it to do a proper update

@larsoner larsoner closed this Sep 28, 2026
@tsbinns

tsbinns commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Sounds good. I'll have a look

@tsbinns
tsbinns deleted the spec_zero branch September 28, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants