Skip to content

DRY dipole code and comment on implementation - #14350

Open
larsoner wants to merge 1 commit into
mne-tools:mainfrom
larsoner:gof-whiten-comment
Open

larsoner wants to merge 1 commit into
mne-tools:mainfrom
larsoner:gof-whiten-comment

Conversation

@larsoner

Copy link
Copy Markdown
Member

Closes #14346

@wmvanvliet I can explain further but I'm hoping this comment would have been sufficient for you to get an answer from the code?

  1. DRY code to reuse existing GOF functions
  2. Add comment to GOF function about what it's doing and why
  3. Improve equivalence tests between GOF functions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "explained variance" to dipole fitting GUI

2 participants