Add stdio support for EverythingServer sample (continues #950) - #1880
Open
FengFafa97 wants to merge 6 commits into
Open
FengFafa97 wants to merge 6 commits into
FengFafa97 wants to merge 6 commits into
Conversation
Co-authored-by: asklar <22989529+asklar@users.noreply.github.com>
Co-authored-by: asklar <22989529+asklar@users.noreply.github.com>
- EverythingServerExtensions.cs: SampleAsync's named parameter was renamed to chatOptions upstream; update the call site. - EverythingServer.Core.csproj: suppress MCP9005 (Sampling deprecated per SEP-2577), matching the sibling EverythingServer.Http.csproj. - EverythingServer.Http/Program.cs: suppress MCPEXP002 around the experimental RunSessionHandler assignment, matching the original Program.cs and docs/experimental.md. - launchSettings.json: remove trailing commas that broke JSON parsing and silently disabled both launch profiles. Verified: dotnet build succeeds with 0 warnings/errors, and both transports complete a live MCP initialize handshake (stdio and Streamable HTTP). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #950, fixes #889.
This picks up @asklar's branch splitting
EverythingServerintoEverythingServer.Core/EverythingServer.Http/EverythingServer.Stdio,rebases it onto current
main, and fixes the build breaks that surfacedfrom the rebase:
EverythingServerExtensions.cs:SampleAsync's named parameter wasrenamed to
chatOptionsupstream; updated the call site.EverythingServer.Core.csproj: added theMCP9005suppression(Sampling deprecated per SEP-2577) that
EverythingServer.Http.csprojalready had — it doesn't propagate across the project reference.
EverythingServer.Http/Program.cs: restored theMCPEXP002pragmaaround the experimental
RunSessionHandlerassignment, matching theoriginal
Program.csanddocs/experimental.md.launchSettings.json: removed trailing commas that broke JSON parsingand silently disabled both launch profiles.
Verification:
dotnet build: 0 warnings, 0 errors.initializehandshake against each (stdio via piped JSON-RPC, HTTP via a direct
POST to the Streamable HTTP endpoint).
Out of scope for this PR:
main'sProgram.csalso gained newsample content since @asklar's branch was cut (icon/
ServerInfometadatashowcase, explicit stateful
SessionMode). Not ported here to keep thisPR focused on restoring a green build; happy to follow up separately.
Co-Authored-By: Claude Sonnet 5