Skip to content

fix(web): surface InspectorClient error events - #1471

Closed
go165 wants to merge 1 commit into
modelcontextprotocol:v2/mainfrom
go165:go165/v2-surface-client-errors
Closed

go165 wants to merge 1 commit into
modelcontextprotocol:v2/mainfrom
go165:go165/v2-surface-client-errors

Conversation

@go165

@go165 go165 commented Jun 14, 2026

Copy link
Copy Markdown

Summary

  • expose the existing InspectorClient error event as lastError from useInspectorClient
  • show a deduped connection-error toast when the hook reports an error status with a reason
  • pin SDK subpath aliases used by repo-root unit tests so App.test.tsx resolves core imports from clients/web/node_modules

Fixes #1323

Validation

  • cd clients/web && npm test -- src/test/core/react/useInspectorClient.test.tsx src/App.test.tsx
  • ./clients/web/node_modules/.bin/prettier --check core/react/useInspectorClient.ts clients/web/src/App.tsx clients/web/src/App.test.tsx clients/web/src/test/core/react/useInspectorClient.test.tsx
  • cd clients/web && ./node_modules/.bin/eslint src/App.tsx src/App.test.tsx src/test/core/react/useInspectorClient.test.tsx vite.config.ts
  • git diff --check

@cliffhall

Copy link
Copy Markdown
Member

Closing: this has gone stale.

It was opened 2026-06-14 against v2/main, and v2/main has moved a long way since. GitHub reports the branch as CONFLICTING — it no longer merges cleanly, and the files it touches have been through substantial change in the intervening three months, so rebasing would be closer to rewriting it than to resolving conflicts.

The delay in getting back to you is on us, and the time you spent on this is appreciated.

Since this was opened, the repo has moved to an issues, not pull requests policy — see CONTRIBUTING.md. Maintainers handle design and implementation, and external contributions come in as detailed issues instead. That policy postdates this PR, so it is not the reason for closing; the staleness is.

If the problem this fixes still reproduces on current v2/main, please open an issue — a lot has changed in this area and some of it may already be addressed, but if it is not, an issue is the way to get it picked up. Useful to include: what you expected, what happens instead, and how to reproduce it. If you already have a fix in mind, the CONTRIBUTING policy asks for the prompt you used and any screenshots rather than a diff.

@cliffhall cliffhall added the v2 Issues and PRs for v2 label Sep 18, 2026
@cliffhall cliffhall closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Issues and PRs for v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants