-
Notifications
You must be signed in to change notification settings - Fork 4k
feat(client): support HTTP auth in ClientSessionGroup #3516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
musi22
wants to merge
5
commits into
modelcontextprotocol:main
Choose a base branch
from
musi22:feat/session-group-httpx-auth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+266
−2
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
865d13d
feat(client): support HTTP auth in ClientSessionGroup
c4d7ef2
docs: wrap session group auth example in async function
2ad805d
test: exercise auth_flow to achieve 100% test file coverage
0b15b01
test: remove obsolete pragma and isolate session establishment in tests
741fc75
test: use patch decorators on session tests to prevent python 3.14 br…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -70,6 +70,35 @@ If you already hold a connected `ClientSession` (`Client.session` is one), hand | |||||
|
|
||||||
| `ClientSessionGroup` is built on `ClientSession`, not on `Client`. Each `connect_to_server` runs the classic `initialize` handshake. It never sends the `server/discover` probe described in **[Protocol versions](../protocol-versions.md)**. Every MCP server understands that handshake, so this costs you compatibility with nothing; it only means a group takes the older, slower path to a server that could do better. | ||||||
|
|
||||||
| ## Authentication | ||||||
|
|
||||||
| When connecting to HTTP servers using `StreamableHttpParameters` or `SseServerParameters`, you can configure an authentication provider (such as an OAuth 2.0 `OAuthClientProvider` or custom `httpx2.Auth` handler) via the `auth=` parameter: | ||||||
|
|
||||||
| ```python | ||||||
| from mcp.client.auth import OAuthClientProvider | ||||||
| from mcp.client.session_group import ClientSessionGroup, StreamableHttpParameters | ||||||
|
|
||||||
|
|
||||||
| async def main() -> None: | ||||||
| server_auth = OAuthClientProvider( | ||||||
| server_url="https://api.example.com", | ||||||
| client_metadata=client_metadata, | ||||||
| storage=token_storage, | ||||||
| redirect_handler=redirect_handler, | ||||||
| callback_handler=callback_handler, | ||||||
| ) | ||||||
|
|
||||||
| server_params = StreamableHttpParameters( | ||||||
| url="https://api.example.com/mcp", | ||||||
| auth=server_auth, | ||||||
| ) | ||||||
|
|
||||||
| async with ClientSessionGroup() as group: | ||||||
| await group.connect_to_server(server_params) | ||||||
| ``` | ||||||
|
|
||||||
| Because `auth` is configured per `ServerParameters` instance, each server in the session group maintains independent authentication context, scopes, and token-refresh lifecycle. Custom headers can still be supplied alongside `auth` via `headers=`. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: When the same auth object is assigned to two parameter instances, Prompt for AI agents
Suggested change
|
||||||
|
|
||||||
| ## Recap | ||||||
|
|
||||||
| * `ClientSessionGroup` holds many server connections and merges their tools, resources, and prompts into one `dict` each. | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The new
main()is never invoked, so copying this authentication example only defines the function and never connects to the server. Add an async runner such asasyncio.run(main())and its import.Prompt for AI agents