Skip to content

fix: reject *args and **kwargs on tool signatures - #3527

Closed
gyanu2507 wants to merge 1 commit into
modelcontextprotocol:mainfrom
gyanu2507:fix/reject-tool-variadic-params
Closed

gyanu2507 wants to merge 1 commit into
modelcontextprotocol:mainfrom
gyanu2507:fix/reject-tool-variadic-params

Conversation

@gyanu2507

@gyanu2507 gyanu2507 commented Sep 18, 2026

Copy link
Copy Markdown

Fixes #3514

Registering a tool whose signature has *args or **kwargs currently succeeds, and list_tools advertises args/kwargs as a required scalar. There is no JSON object that can fill that field the way the function actually receives it, so the tool is permanently uncallable.

This raises InvalidSignature at registration, matching the existing rejection of a leading underscore in a parameter name. Resource templates still pass allow_variadic=True because they legitimately use **kwargs for URI variables that are only known at match time.

Tested for both *args and **kwargs tools, and that a **kwargs resource template still registers.

A tool with a variadic parameter is advertised with a schema that can
never be satisfied, so the call always fails validation. Raise
InvalidSignature at registration, the same way a leading underscore
already is. Resource templates still allow **kwargs for URI variables
that are only known at match time.
@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3514.

If a maintainer assigns you to #3514, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

@github-actions github-actions Bot closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A tool with a *args or **kwargs parameter is registered with a schema it can never satisfy

1 participant