Conversation
RFC 6570 section 3.1 requires literals that are not valid in a URI to be UTF-8 percent-encoded on expand. match() used the same raw literals, so a resource template with cafe or a space in the path was listed but could never be read once AnyUrl encoded the URI on the wire.
github-actions
Bot
added
the
missing-issue-link
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3526. If a maintainer assigns you to #3526, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
1 participant
Fixes #3526
UriTemplatecopied literal runs into expand/match verbatim. RFC 6570 section 3.1 requires a literal the URI grammar does not allow (for example cafe with an accent, or a space) to be UTF-8 percent-encoded. The encoded form is also what pydantic AnyUrl puts on the wire, so a resource template with a non-ASCII or space literal was listed and could never be read.Literals are now encoded with the existing
_encode(..., allow_reserved=True)helper, so expand and match share the same encoded atoms. After this change, the raw unencoded IRI no longer matches. That is the RFC 3986 form a server never sees over the wire.Tested with the uritemplate-test literal-encoding case, a space in the path, round-trip match of the encoded URI, and a resource-template matches() case.