Conversation
DaleSeo
marked this pull request as ready for review
October 3, 2026 03:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
uuid1.27.0 came out on Oct 2 and requires Rust 1.89. We don't commitCargo.lock, so every CI run resolves the newest versions. The MSRV job now picksuuid1.27.0 and fails withrustc 1.88.0 is not supported(seen on #1248).mainpassed only because its last run finished before the release. The next run will hit the same failure.The workspace uses edition 2024, where resolver 3 is the default. But
resolver = "2"was set explicitly, which turned off MSRV-aware fallback. With resolver 3, Cargo picks the newest version that works with 1.88 instead. Resolver settings apply only inside this workspace, so downstream users ofrmcpare not affected.How Has This Been Tested?
cargo +1.88 check --all-targets --all-featuresBreaking Changes
None.
Types of changes
Checklist