Skip to content

memory: expect Node 26's path-suffixed EISDIR message in persistence test #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cliffhall merged 1 commit into from
Oct 10, 2026
Merged

memory: expect Node 26's path-suffixed EISDIR message in persistence test #5078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/memory/__tests__/persistence.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,11 @@ describe("memory persistence over the protocol", () => {
// which is not the ENOENT that means "no graph yet".
await fs.mkdir(filePath);
const { client } = await open();
// Node 26 appends the path to the message; earlier versions do not
// (#5076). The server passes Node's message through either way.
const bare = "EISDIR: illegal operation on a directory, read";
const nodeMajor = Number(process.versions.node.split(".")[0]);
const expected = nodeMajor >= 26 ? `${bare} '${filePath}'` : bare;

for (const [name, args] of [
["read_graph", {}],
Expand All @@ -220,9 +225,7 @@ describe("memory persistence over the protocol", () => {
] as const) {
const result = await call(client, name, args);
expect(result.isError).toBe(true);
expect(textOf(result)).toBe(
"EISDIR: illegal operation on a directory, read",
);
expect(textOf(result)).toBe(expected);
}
await expect(
client.readResource({ uri: "memory://knowledge-graph" }),
Expand Down
Loading