Repository navigation
Validate OAuth issuers and registration metadata - #293
EhsanAzish80 wants to merge 2 commits into
Conversation
|
The issuer check still accepts Authorization Server Metadata that omits
if let issuer = asMetadata.issuer,
issuer.absoluteString != candidateServer.absoluteStringso a document with no That matters even more in this PR because later authorization-response validation falls back to Could discovery reject a missing issuer as well as a mismatched issuer, with a regression for a 200 metadata document that has endpoints but no AI-assisted review; checked the current PR head against RFC 8414 issuer requirements before posting. |
|
Fixed the missing issuer case in c5374db. A 200 metadata response without an issuer now fails discovery. All 554 Swift tests passed locally. AI helped write the new test; I ran it. Could a maintainer review this and approve the CI workflow? |
Checks OAuth issuer metadata and callback issuers before using an authorization code. It also sends the client application type during registration and starts a new registration when the authorization server changes. Related to #231 and #242.
Tests: 553 Swift tests passed locally. AI was used to write the tests. I ran them locally.