Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modern_di/dependency_graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ def collect_errors(registry: "ProvidersRegistry") -> list[Exception]:
if type(event) is Edge:
parent, name, dep = event
dependency_chain = terminal_chain(dep, registry)
if dependency_chain[-1]._ignores_scope: # noqa: SLF001
continue
dependency_scope = dependency_chain[-1].scope
parent_scope = effective_scope(parent, registry)
if dependency_scope > parent_scope:
Expand Down
8 changes: 7 additions & 1 deletion modern_di/providers/abstract.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ class AbstractProvider(typing.Generic[types.T_co]):
_takes_group_scope: typing.ClassVar[bool] = True
"""Whether a Group-level default scope applies. False when the effective scope is derived."""

_ignores_scope: typing.ClassVar[bool] = False
"""Whether resolution ignores this provider's scope."""

def __init__(
self,
*,
Expand All @@ -44,7 +47,10 @@ def provider_id(self) -> int:

@property
def scope(self) -> enum.IntEnum:
"""The effective scope: the provider's own ``scope=``, else a Group default, else ``Scope.APP``."""
"""The declared scope: the provider's own ``scope=``, else a Group default, else ``Scope.APP``.

A redirect such as ``Alias`` resolves at its source's scope instead.
"""
if self._explicit_scope is not None:
return self._explicit_scope
if self._group_claim is not None:
Expand Down
8 changes: 8 additions & 0 deletions modern_di/providers/container_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,17 @@ class _ContainerProvider(AbstractProvider[typing.Any]):
__slots__ = ()

_takes_group_scope = False
_ignores_scope = True

def __init__(self) -> None:
super().__init__(scope=Scope.APP, bound_type=None)

def __repr__(self) -> str:
return "container_provider"

@property
def display_name(self) -> str:
return "Container"


container_provider = _ContainerProvider()
22 changes: 22 additions & 0 deletions tests/test_custom_scope.py
Original file line number Diff line number Diff line change
Expand Up @@ -357,3 +357,25 @@ class DeeperGroup(Group):
Container(groups=[DeeperGroup]).validate()
(issue,) = exc.value.exceptions
assert isinstance(issue, InvalidScopeDependencyError)


@dataclasses.dataclass(kw_only=True, slots=True)
class _NeedsContainer:
container: Container


@pytest.mark.parametrize("members", [{"APP": 1, "REQ": 2}, {"APP": 0, "REQ": 1}])
def test_validate_accepts_container_injection_under_a_custom_scope_enum(members: dict[str, int]) -> None:
custom = enum.IntEnum("custom", members)

class ContainerGroup(Group):
needs_container = providers.Factory(creator=_NeedsContainer, scope=custom.APP)

container = Container(groups=[ContainerGroup], scope=custom.APP)
container.validate()
assert container.resolve(_NeedsContainer).container is container


def test_container_provider_displays_as_container() -> None:
assert providers.container_provider.display_name == "Container"
assert repr(providers.container_provider) == "container_provider"
Loading