Skip to content

docs: fix the container link label and rewrap a lifecycle paragraph (#614) - #623

Merged
lesnik512 merged 1 commit into
mainfrom
issue-614-followup
Oct 9, 2026
Merged

lesnik512 merged 1 commit into
mainfrom
issue-614-followup

Conversation

@lesnik512

Copy link
Copy Markdown
Member

Refs #614. Follow-up to #619, which merged before these review fixes landed.

Summary

Test plan

  • just lint-ci
  • mkdocs build --strict

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: b969c7c Previous: 68d4685 Ratio
benchmarks/test_guard_by_type.py::test_g16_resolve_by_type 5250260.4916757215 iter/sec (stddev: 5.488108542451633e-9) 2909479.2346332557 iter/sec (stddev: 1.2209540774992632e-8) 0.55
benchmarks/test_guard_by_type.py::test_g17_resolve_by_type_large_registry 5206333.775778035 iter/sec (stddev: 8.979078061241035e-9) 2877933.459589614 iter/sec (stddev: 1.1266063666075538e-8) 0.55
benchmarks/test_guard_cold.py::test_g8_cold_first_resolve 31425.493520066993 iter/sec (stddev: 0.00003272599996154759) 21624.408994070352 iter/sec (stddev: 0.00004353392440193875) 0.69
benchmarks/test_guard_cold.py::test_g8b_cold_first_resolve_cached 24036.693635545736 iter/sec (stddev: 0.00009996354361875454) 16062.33555433443 iter/sec (stddev: 0.0001171580280804952) 0.67
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[1] 678.9101326830979 iter/sec (stddev: 0.000035659226728141434) 372.41718647604426 iter/sec (stddev: 0.00004103336503727921) 0.55
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[2] 644.5247053089607 iter/sec (stddev: 0.000027453834310064512) 356.7992411536997 iter/sec (stddev: 0.00010414956223461677) 0.55
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[4] 620.1209974932224 iter/sec (stddev: 0.00003334928495439897) 349.3945837398324 iter/sec (stddev: 0.00008169499576812023) 0.56
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[1] 17880.952196617833 iter/sec (stddev: 0.000005443918657256002) 11812.232748260863 iter/sec (stddev: 0.000008706869035475766) 0.66
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[2] 9427.465317505612 iter/sec (stddev: 0.000019349953677404483) 6162.507479098245 iter/sec (stddev: 0.000025125312663039706) 0.65
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[4] 5002.43660347339 iter/sec (stddev: 0.00002662569076705344) 3297.539096035311 iter/sec (stddev: 0.00004497466493849032) 0.66
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[1] 12242.429485479766 iter/sec (stddev: 0.000007825171620036418) 8346.554507511004 iter/sec (stddev: 0.000011356964731263443) 0.68
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[2] 5532.65982114593 iter/sec (stddev: 0.000014033333365821936) 3539.135539602003 iter/sec (stddev: 0.00002735460345472286) 0.64
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[4] 2495.4603936210124 iter/sec (stddev: 0.00004057373407363137) 1671.7936631028952 iter/sec (stddev: 0.00005203837697615841) 0.67
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[1] 48404.33105888838 iter/sec (stddev: 0.0000037020207029731187) 39542.66274335896 iter/sec (stddev: 0.000005463304072352007) 0.82
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[2] 20440.962667203512 iter/sec (stddev: 0.000010029075592177481) 12754.883765290642 iter/sec (stddev: 0.000014849567578399732) 0.62
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[4] 8629.335108245661 iter/sec (stddev: 0.00002275981499743535) 5954.360422798371 iter/sec (stddev: 0.000034390868545997847) 0.69
benchmarks/test_guard_lifecycle.py::test_g6_build_child_container 2188073.805268923 iter/sec (stddev: 2.1832022159184014e-8) 1611961.9830068543 iter/sec (stddev: 3.411756829069379e-8) 0.74
benchmarks/test_guard_lifecycle.py::test_g6b_build_child_container_auto_scope 2176421.25069219 iter/sec (stddev: 1.532063322002582e-8) 1668358.1733119658 iter/sec (stddev: 1.9225815213946484e-8) 0.77
benchmarks/test_guard_lifecycle.py::test_g7_request_lifecycle_batch 3935.5233956733778 iter/sec (stddev: 0.000014946512987327478) 2839.2156896899733 iter/sec (stddev: 0.000013756369070727859) 0.72
benchmarks/test_guard_lifecycle.py::test_g7c_event_loop_floor_control 75935.28242467175 iter/sec (stddev: 0.0000010027984753083414) 58283.47481855502 iter/sec (stddev: 0.0000021182512433194013) 0.77
benchmarks/test_guard_lifecycle.py::test_g7b_request_cycle_sync 474111.19381824066 iter/sec (stddev: 5.696896839022865e-8) 345822.7268781275 iter/sec (stddev: 9.286792412299475e-8) 0.73
benchmarks/test_guard_lifecycle.py::test_g13_teardown_at_scale 70065.32204773914 iter/sec (stddev: 0.0000011085281159642423) 49603.6366139206 iter/sec (stddev: 0.000002253219725869423) 0.71
benchmarks/test_guard_lifecycle.py::test_g13b_teardown_at_scale_async_no_finalizers 654.491244832814 iter/sec (stddev: 0.0010366801730323566) 467.50081550218664 iter/sec (stddev: 0.0011356040431617868) 0.71
benchmarks/test_guard_resolve.py::test_g1_transient_resolve 3034950.6433477774 iter/sec (stddev: 1.803879420311217e-8) 2007530.2459533864 iter/sec (stddev: 3.634368716167373e-8) 0.66
benchmarks/test_guard_resolve.py::test_g2_cached_resolve 5038305.988527535 iter/sec (stddev: 7.00264331151376e-9) 2826321.578077196 iter/sec (stddev: 1.0206665323835546e-8) 0.56
benchmarks/test_guard_resolve.py::test_g3_deep_chain 1017312.3675439942 iter/sec (stddev: 3.574719079844085e-8) 570436.8588003246 iter/sec (stddev: 3.036574585356185e-7) 0.56
benchmarks/test_guard_resolve.py::test_g4_wide_resolve 597639.2175139748 iter/sec (stddev: 3.3844754121258604e-7) 362138.9192055074 iter/sec (stddev: 8.162549886939354e-7) 0.61
benchmarks/test_guard_resolve.py::test_g5_cross_scope 2721192.8403159035 iter/sec (stddev: 2.187607435385907e-8) 1846794.371263989 iter/sec (stddev: 4.1151240163164876e-8) 0.68
benchmarks/test_guard_resolve.py::test_g9_context_resolve 2062144.476633105 iter/sec (stddev: 1.3046068148661762e-7) 1323622.1821050942 iter/sec (stddev: 1.6394004416591575e-7) 0.64
benchmarks/test_guard_resolve.py::test_g12_override_active_resolve 1006650.3347756484 iter/sec (stddev: 3.110811701085966e-8) 726452.5755240317 iter/sec (stddev: 6.983069484850424e-8) 0.72
benchmarks/test_guard_resolve.py::test_g18_alias_hop 4926904.688412219 iter/sec (stddev: 1.2306178281835738e-8) 3043187.9804295627 iter/sec (stddev: 1.3990043802709667e-8) 0.62
benchmarks/test_guard_validate.py::test_g10_validate_deep_chain 40564.83284524164 iter/sec (stddev: 0.00001741677946301052) 27066.48777162898 iter/sec (stddev: 0.00002303542056745669) 0.67
benchmarks/test_guard_validate.py::test_g11_validate_wide 23470.266508978755 iter/sec (stddev: 0.000021456532370891283) 16256.564834377594 iter/sec (stddev: 0.000027449817603891526) 0.69

This comment was automatically generated by workflow using github-action-benchmark.

@lesnik512
lesnik512 merged commit 24b961a into main Oct 9, 2026
11 checks passed
@lesnik512
lesnik512 deleted the issue-614-followup branch October 9, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant