Repository navigation
fix(test-runner-core): fail sessions on returned teardown errors - #3168
Open
raashish1601 wants to merge 1 commit into
Open
raashish1601 wants to merge 1 commit into
raashish1601 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 4cb14c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
When a custom browser launcher resolves
stopSession()with anerrorsarray after its tests pass, the session keepspassed: trueand can make the run report success. Route returned errors through the existing failure accumulator, matching thrown teardown errors, and add a regression test and patch changeset.Validation:
npm run build, including TypeScript project checks.test-runner-coretests against compiled output with one test worker.npm run lint, plus standalone full Prettier and changed-file formatting checks.lint-stagedpre-commit hook.A combined lint retry reached a 300-second local limit. The standalone formatter subsequently passed. Windows checkout line endings were normalized locally without adding unrelated changes to the commit.
AI assistance: this change and its tests were developed with OpenAI Codex.