Repository navigation
chore(bson-parsing): integration with compass - #910
Merged
Merged
Conversation
mabaasit
added this pull request to stack #894
October 5, 2026 13:01
mabaasit
force-pushed
the
integration-clean-up
branch
from
October 5, 2026 13:04
a141a27 to
504988a
Compare
mabaasit
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The test imports named exports from a worker file that Webpack overwrites with a non-exporting IIFE bundle.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates the BSON parser worker for Compass compatibility while preserving parser error types.
Changes:
- Renames worker artifacts to
.mjs. - Transfers
Errorobjects across the worker boundary. - Adds error-type preservation coverage.
| File | Description |
|---|---|
webpack.worker.config.cjs |
Bundles the worker as worker.mjs. |
src/worker.mts |
Returns parser errors directly. |
src/worker-types.ts |
Types worker failures as Error. |
src/worker-client.ts |
Loads .mjs and rejects with transferred errors. |
src/index.spec.ts |
Updates worker paths and tests error preservation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mabaasit
force-pushed
the
integration-clean-up
branch
2 times, most recently
from
October 5, 2026 15:20
c4bd7b3 to
107e42d
Compare
mabaasit
force-pushed
the
integration-clean-up
branch
from
October 5, 2026 15:47
107e42d to
ca1a8ac
Compare
mabaasit
force-pushed
the
integration-clean-up
branch
from
October 5, 2026 19:44
ca1a8ac to
8c55a75
Compare
mabaasit
force-pushed
the
integration-clean-up
branch
from
October 5, 2026 20:30
8c55a75 to
5126e9d
Compare
3 tasks
mabaasit
force-pushed
the
integration-clean-up
branch
from
October 8, 2026 21:42
6ca851c to
4372c96
Compare
mabaasit
force-pushed
the
integration-clean-up
branch
from
October 9, 2026 23:03
4372c96 to
1af7a1c
Compare
mabaasit
force-pushed
the
integration-clean-up
branch
2 times, most recently
from
October 14, 2026 09:52
75bd63f to
2df8ad5
Compare
mabaasit
marked this pull request as ready for review
October 14, 2026 10:01
| blobUrl = URL.createObjectURL(new Blob([code], { type: 'text/javascript' })); | ||
| // Compass Web injects whatwg-url for bare URL references; it lacks blob APIs. | ||
| // Use the native constructor for blob creation and revocation. | ||
| blobUrl = globalThis.URL.createObjectURL( |
Collaborator
There was a problem hiding this comment.
Is globalThis.URL.createObjectURL always a function?
| // On browser env we want to fetch and blob so that the worker | ||
| // script can run on the web running locally. | ||
| const scriptUrl = new URL('./worker.js', import.meta.url); | ||
| if (scriptUrl.protocol === 'file:') { |
Collaborator
There was a problem hiding this comment.
Should we test this if file: path?
Anemy
approved these changes
Oct 15, 2026
Anemy
reviewed
Oct 15, 2026
| ): void { | ||
| if (worker) worker.terminate(); | ||
| if (blobUrl) URL.revokeObjectURL(blobUrl); | ||
| if (blobUrl) globalThis.URL.revokeObjectURL(blobUrl); |
Collaborator
Author
There was a problem hiding this comment.
Yes, this showed in the integration with compass-web. There we alias url to whatwg-url and it does not have these methods.
mabaasit
force-pushed
the
integration-clean-up
branch
from
October 15, 2026 10:54
9c6fcdd to
75b942a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Open Questions
Checklist
Stack created with GitHub Stacks CLI • Give Feedback 💬