Repository navigation
fix(mongodb-downloader): replace decompress with maintained @xhmikosr/decompress - #927
Merged
Merged
Conversation
lerouxb
commented
Oct 14, 2026
| @@ -0,0 +1,22 @@ | |||
| declare module '@xhmikosr/decompress' { | |||
Member
Author
There was a problem hiding this comment.
@xhmikosr/decompress@11.1.4 ships no types; excluding the declaration produces TS7016 and an implicit-any error in the filter callback.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new declaration incorrectly types runtime Date values as strings.
0 open findings
What changed in this PR
Replaces the unmaintained decompression dependency used for MongoDB ZIP artifacts.
Changes:
- Migrates to
@xhmikosr/decompress. - Adds local TypeScript declarations.
- Adds ZIP extraction regression tests.
| File | Description |
|---|---|
packages/mongodb-downloader/src/index.ts |
Updates the decompressor import. |
packages/mongodb-downloader/src/index.spec.ts |
Tests ZIP extraction behavior. |
packages/mongodb-downloader/src/decompress.d.ts |
Declares the dependency API. |
packages/mongodb-downloader/package.json |
Replaces dependencies and typings. |
package-lock.json |
Updates resolved dependency versions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kmruiz
approved these changes
Oct 14, 2026
lerouxb
enabled auto-merge (squash)
October 14, 2026 11:40
lerouxb
disabled auto-merge
October 14, 2026 12:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.