JAVA-6236 add builder API for facet without operator and clean up search api from beta Reason.SERVER - #2006
Open
strogiyotec wants to merge 11 commits into
Open
JAVA-6236 add builder API for facet without operator and clean up search api from beta Reason.SERVER#2006strogiyotec wants to merge 11 commits into
strogiyotec wants to merge 11 commits into
Conversation
|
Assigned |
stIncMale
requested changes
Jul 6, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
stIncMale
requested changes
Jul 8, 2026
strogiyotec
changed the title
stIncMale
requested changes
Oct 2, 2026
| */ | ||
| @Beta({Reason.CLIENT, Reason.SERVER}) | ||
| @Beta(Reason.CLIENT) | ||
| static FacetSearchCollector facet(final SearchOperator operator, final Iterable<? extends SearchFacet> facets) { |
Member
There was a problem hiding this comment.
I have just realized: now that the facet methods here and below are annotated the same way SearchCollector is (@Beta(Reason.CLIENT)), we no longer need this annotation on the methods.
Previously it had to be there because the methods were beta also due to the server (and were annotated @Beta({Reason.CLIENT, Reason.SERVER})), which differed from the reason SearchCollector was beta (@Beta(Reason.CLIENT)).
The same applies to the SearchCollector in Scala.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JAVA-6236 add builder API for facet without operator
Existing API marks
operatoras mandatory but latestfacetAPI makes it optionalhttps://www.mongodb.com/docs/search/query/operators-collectors/facet/
Also removed
@Beta Reason.SERVERfrom all classes inmodel/searchexcept for VectorSearchQuery, TextVectorSearchQuery