Repository navigation
feat: add explicit read-write filesystem grants across APIs - #275
Draft
jamesboyzj-design wants to merge 1 commit into
Draft
jamesboyzj-design wants to merge 1 commit into
jamesboyzj-design wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an explicit read/execute + write grant so callers can state combined authority before #150 changes
fs_writeto pure-write semantics. Existingfs_writebehavior is unchanged here; this preparatory PR does not close #150.The entry point is available as Rust
fs_read_writeon SandboxBuilder and ConfinementBuilder,--fs-read-writein the CLI,sandlock_sandbox_builder_fs_read_writein C,fs_read_writein Python,FSReadWritein Go, and[filesystem].read_writein TOML. Grants normalize to both read and write lists; profile export/reload preserves authority. Python forwards the new field, and Go includes it in NUL validation before allocating a builder.Validation on exact commit
50d3707, based directly on main1e697ce(independent of PR #274): Linux aarch64, Rust 1.96, tests run as uid/gid 65534 in a non-privileged Docker container with seccomp unconfined. Core unit tests: 881 passed; C ABI filesystem tests: 9 passed; CLI tests: 33 passed; Python profile/config tests: 96 passed; five Go profile/new-API tests passed, including actual creation and readback. C header matches cbindgen 0.29.2 output; git diff --check passes. Distinct x86_64 behavior and full workspace/SDK suites are left to CI; checkpoint restore is not validated locally.Remaining #150 work is the coordinated pure-write enforcement and migration: Landlock, chroot, procfs, COW injected descriptors and upper-layer reads, existing defaults/examples, and overlapping-read diagnostics. No path-based append-only guarantee is introduced.