Repository navigation
Proposal: Format SQL around standalone psql commands - #84
Closed
arnodirlam wants to merge 1 commit into
Closed
arnodirlam wants to merge 1 commit into
arnodirlam wants to merge 1 commit into
Conversation
Owner
|
As explained in #83, I'm rejecting this. The parsing code should live inside a parser. Also, I'd like to avoid a regex-based parsing approach. I'd really prefer having a proper grammar defined for it. Additional thing to note is the handling of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposal for #83: format PostgreSQL between standalone psql commands while preserving the command lines and arguments.
With
parser: "psql"and otherwise default options:Before:
After:
The separate parser makes this opt-in. It never adds final semicolons, even with
sqlFinalSemicolon: true, since doing so before\gsetcould execute the query twice.This deliberately starts small: unparseable SQL fragments stay as written, including unsupported psql variable interpolation and inline commands. Scripts mentioning
COPYremain untouched to protect inline data; that conservative check also catches mentions in comments and strings.I'd appreciate your thoughts on whether this belongs here or in the underlying parser, and whether preserving unsupported fragments is the right behavior. Feel free to close this PR if it isn't wanted.