Skip to content

Align Node 22.23.3 and npm runtime pins - #3131

Closed
ktsaou wants to merge 1 commit into
masterfrom
deps/refresh-pinned-node-runtime
Closed

ktsaou wants to merge 1 commit into
masterfrom
deps/refresh-pinned-node-runtime

Conversation

@ktsaou

@ktsaou ktsaou commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Pin Node 22.23.3 and bundled npm 10.9.9 across Learn deployment, CI and the development container. Align existing exact assertions and current developer/first-touch validation instructions. Yarn, dependencies, renderer and shared vendors remain unchanged.

The existing redirect writer regenerates the static Netlify section; all dynamic redirect bytes are identical. Validation under the official runtime passes a forced frozen Yarn install, the complete 2,032-page publication build and the uninterrupted existing test command: 490 Vitest checks, one existing skip and all 99 Node checks.


Summary by cubic

Aligned Node 22.23.3 and npm 10.9.9 pins across Learn deployment, CI workflows, the dev container, and developer docs.

  • Updated the version assertions in src/seo/deploymentIntegrations.test.js to match.
  • Yarn, dependencies, and generated static output are unchanged; the full build and test suite pass.

Written for commit 8f2faa2. Summary will update on new commits.

View guided diff Turn on auto-fix

@ktsaou
ktsaou requested a review from a team as a code owner October 9, 2026 00:25
@ktsaou
ktsaou requested review from mtblz and witalisoft October 9, 2026 00:25
@netlify

netlify Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for netdata-docusaurus ready!

Name Link
🔨 Latest commit 8f2faa2
🔍 Latest deploy log https://app.netlify.com/projects/netdata-docusaurus/deploys/6ac8347d66f34d0008f572ba
😎 Deploy Preview https://deploy-preview-3131--netdata-docusaurus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5f716599-ad35-4fdd-bd79-effd4bb22979
📥 Commits

Reviewing files that changed from the base of the PR and between 3e846ee and 8f2faa2.

📒 Files selected for processing (8)
  • .devcontainer/devcontainer.json
  • .github/workflows/generated-output-boundary.yml
  • .github/workflows/rendered-link-integrity.yml
  • FIRST-TOUCH-ATTRIBUTION.md
  • README.md
  • netlify.toml
  • src/seo/deploymentIntegrations.test.js
  • static.toml
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.
Architecture diagram
sequenceDiagram
    participant Dev as Developer
    participant DevCont as Dev Container
    participant CI as CI Workflows
    participant Build as Netlify Build
    participant Test as Test Suite
    participant Repo as Repo Config

    Note over Dev,Build: Runtime Version Alignment Flow

    Dev->>DevCont: Start development environment
    DevCont->>DevCont: Use node:22.23.3 image

    Dev->>Repo: Follow README instructions
    Repo-->>Dev: Node 22.23.3 + npm 10.9.9

    Dev->>CI: Push code
    CI->>CI: generated-output-boundary workflow
    CI->>CI: Setup Node 22.23.3
    CI->>Repo: Verify generated output ownership
    CI->>CI: rendered-link-integrity workflow
    CI->>CI: Setup Node 22.23.3 (NODE_VERSION env)

    CI->>Build: Trigger deployment
    Build->>Repo: Read netlify.toml config
    Repo-->>Build: NODE_VERSION=22.23.3, NPM_VERSION=10.9.9
    Build->>Build: Run build:netlify
    Build->>Test: Execute test suite
    Test->>Repo: Read static.toml config
    Repo-->>Test: NODE_VERSION=22.23.3, NPM_VERSION=10.9.9
    Test->>Test: deploymentIntegrations.test.js
    Test->>Repo: Verify version assertions
    Repo-->>Test: Assertions pass
    Test->>Test: 490 Vitest + 99 Node checks
    Test-->>Build: All tests pass
    Build-->>CI: Success
    Build-->>Dev: Deployment complete
Loading

View guided diff | Turn on auto-fix | Re-trigger cubic

@ktsaou
ktsaou marked this pull request as draft October 9, 2026 09:36
@ktsaou

ktsaou commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

Superseded by #3136 (#3136), which combines all supported Learn package, runtime, tooling and copied-browser-asset updates with a fresh inventory and combined validation. This proposal's history and branch are retained; review the combined draft instead.

@ktsaou ktsaou closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant