feat(open-file): remove syncing dialog by alperozturk96 · Pull Request #17725 · nextcloud/android

alperozturk96 · 2026-09-28T11:41:18Z

Implements: #17574

Test scenarios: opening a file from the file list

"Changed" means the file was edited on the web and the app noticed it during the folder refresh. To get there: edit the file on the web, stay in the folder and wait ~15s before tapping.

#	Tapped file in the file list	Before	After
1	Image that isn't downloaded, unchanged	Preview opens, sometimes after a server check	Preview opens immediately, no dialog
2	Image that isn't downloaded, changed	Loading dialog while the full image downloads, then preview	Preview opens immediately with the resized image, no dialog
3	Downloaded text file, unchanged	Preview opens, sometimes after a server check	Preview opens immediately, no dialog
4	Downloaded text file, changed	Loading dialog while syncing, then preview	Syncs in the background, then preview shows the new content, no dialog
5	Downloaded text file, changed on the web and edited locally (conflict)	Loading dialog, then conflict screen	Conflict screen opens, no dialog
6	Audio file that is still downloading, changed	Loading dialog while syncing, then player	Syncs in the background, then player opens, no dialog
7	Downloaded pdf, docx or other file, unchanged	Loading dialog and full sync on every tap, then external app	External app opens immediately, no dialog
8	Downloaded pdf, docx or other file, changed	Loading dialog while syncing, then external app	Syncs in the background, then external app opens the new version, no dialog
9	Downloaded pdf, docx or other file, conflict	Loading dialog, then conflict screen	Conflict screen opens, no dialog

github-actions · 2026-09-28T11:50:42Z

📱 QA build


Download	app-qa-debug.apk
QR code	Open the QR code for this download
Commit	`42b089c`
Version	`17725`
Available until	7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

codecov · 2026-09-28T12:09:56Z

Codecov Report

❌ Patch coverage is 15.70248% with 102 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...cloud/android/ui/helpers/FileOperationsHelper.java	0.00%	50 Missing ⚠️
...oud/android/operations/RefreshFolderOperation.java	28.57%	22 Missing and 3 partials ⚠️
...wncloud/android/ui/activity/FileDisplayActivity.kt	27.27%	16 Missing ⚠️
...oud/android/operations/SynchronizeFileOperation.kt	0.00%	6 Missing ⚠️
...com/nextcloud/utils/extensions/OCFileExtensions.kt	0.00%	5 Missing ⚠️

📢 Thoughts on this report? Let us know!

alperozturk96 · 2026-10-05T12:05:27Z

If I try to open the .md file from file list, it triggers the public void startSyncForFileAndIntent(OCFile file, Intent intent) are we going to check that logic as well?

Because internally it still calls

private void syncFileOrFolder(OCFile file, User user, FileDataStorageManager storageManager) thus R.string.sync_in_progress will be shown.

Apparently openFile functions is not the only one. @tobiasKaminsky

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

…lse skip. Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

…e visible to other threads) Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

…mageWithSearchContext Downloaded text file via -> fileOnItemClick -> previewFile -> startTextPreview Downloaded audio file via > fileOnItemClick -> previewFile -> startAudioPreview Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

github-actions · 2026-10-06T08:42:04Z

Codacy

SpotBugs

Category	Base	New
Bad practice	30	30
Correctness	54	54
Dodgy code	177	177
Experimental	1	1
Malicious code vulnerability	2	2
Multithreaded correctness	26	21
Performance	35	35
Security	16	16
Total	341	336

alperozturk96 · 2026-10-06T08:43:02Z

+    private void syncAndOpenFile(OCFile file, Intent openFileWithIntent) {
+        User user = currentAccount.getUser();
+        final var storageManager = new FileDataStorageManager(user, fileActivity.getContentResolver());
+        if (isDownloadedAndUpToDate(storageManager.getFileById(file.getFileId()))) {


Only locally checks not goes to server to check eTag. @tobiasKaminsky

alperozturk96 linked an issue Sep 28, 2026 that may be closed by this pull request

Remove "retrieve last version" #17574

Open

alperozturk96 requested a review from tobiasKaminsky September 28, 2026 11:47

alperozturk96 added the 3. to review label Sep 28, 2026

alperozturk96 added this to the Nextcloud App 35.1.0 milestone Sep 28, 2026

alperozturk96 requested a review from daniele-verducci September 28, 2026 11:47

alperozturk96 commented Oct 5, 2026

View reviewed changes

Comment thread app/src/main/java/com/owncloud/android/ui/helpers/FileOperationsHelper.java Outdated

alperozturk96 commented Oct 5, 2026

View reviewed changes

Comment thread app/src/main/java/com/owncloud/android/operations/RefreshFolderOperation.java Outdated

alperozturk96 marked this pull request as draft October 5, 2026 09:39

alperozturk96 added 2. developing and removed 3. to review labels Oct 5, 2026

alperozturk96 force-pushed the feat/remove-retrieve-last-version branch 2 times, most recently from d25e2b2 to a4cfa38 Compare October 5, 2026 10:02

nextcloud deleted a comment from github-actions Bot Oct 5, 2026

alperozturk96 added 11 commits October 6, 2026 09:14

add missing items for mFilesToSyncContents

a5acf40

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

remove sync in progress dialog

f062e0b

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

use kotlin durations

7ee2012

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

reduce auto folder refresh to 10 seconds

f52ec06

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Only add when user open the folder first time not every 10 seconds.

1a5e09c

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Check local eTag if it's outdated then run SynchronizeFileOperation e…

14983fc

…lse skip. Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

simplify openFile function

1053875

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

fix spotbugs: (This write of this shared primitive variable may not b…

ed141f4

…e visible to other threads) Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

simplify startContentSynchronizations

6e8119f

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

print results

d1a1b18

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

only sync when user get in directory

43db26c

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

alperozturk96 force-pushed the feat/remove-retrieve-last-version branch from 9bf50de to 43db26c Compare October 6, 2026 07:14

alperozturk96 added 2 commits October 6, 2026 09:48

no need sync for image preview

42b089c

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

alperozturk96 added 3. to review and removed 2. developing labels Oct 6, 2026

alperozturk96 marked this pull request as ready for review October 6, 2026 08:40

alperozturk96 commented Oct 6, 2026

View reviewed changes

Navigation Menu

Repository navigation

feat(open-file): remove syncing dialog - #17725

feat(open-file): remove syncing dialog#17725
alperozturk96 wants to merge 13 commits into
masterfrom
feat/remove-retrieve-last-version

alperozturk96 commented Sep 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

alperozturk96 commented Oct 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

alperozturk96 Oct 6, 2026 •

edited

Loading

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

alperozturk96 commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implements: #17574

Test scenarios: opening a file from the file list

Uh oh!

github-actions Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📱 QA build

Uh oh!

codecov Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

alperozturk96 commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 6, 2026

Codacy

SpotBugs

Uh oh!

alperozturk96 Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

alperozturk96 commented Sep 28, 2026 •

edited

Loading

github-actions Bot commented Sep 28, 2026 •

edited

Loading

codecov Bot commented Sep 28, 2026 •

edited

Loading

alperozturk96 commented Oct 5, 2026 •

edited

Loading

alperozturk96 Oct 6, 2026 •

edited

Loading