improve unified share fetch - #17770
Open
alperozturk96 wants to merge 2 commits into
Open
alperozturk96 wants to merge 2 commits into
alperozturk96 wants to merge 2 commits into
Conversation
Collaborator
Author
|
/backport to stable-35.0.x |
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
improve-unified-share-fetch
branch
from
October 5, 2026 08:04
46bba3f to
fa42242
Compare
alperozturk96
commented
Oct 5, 2026
|
|
||
| private suspend fun ShareAvatarRepository.fetchSharees(file: OCFile) { | ||
| file.sharees = fetchShareAvatars(file.localId.toString())?.toAvatarSharees().orEmpty() | ||
| val shares = fetchShareAvatars(file.localId.toString()) ?: return |
Collaborator
Author
There was a problem hiding this comment.
Should just return not with empty thus we don't override via false data
alperozturk96
commented
Oct 5, 2026
| } | ||
|
|
||
| if (newShares.isEmpty()) { | ||
| UnifiedShareSharees.fill(user, cachedFiles) |
Collaborator
Author
There was a problem hiding this comment.
Adds missing call
…ground Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.