Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/res/layout/widget_entry.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
android:layout_height="match_parent"
android:layout_weight="1"
android:layout_gravity="center_vertical"
android:gravity="center_vertical"
android:maxLines="1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mark99i thanks for your PR!
This does improve the situation, but in case of long titles, the title is truncated and this is not visible to the user.
We could consider adding an ellipsize to make it clear:

Suggested change
android:maxLines="1"
android:maxLines="1"
android:ellipsize="middle"

I choose "middle" as it allows discerning between names like "Note 1", "Note 2"... and/or conflicted copies.

Before:
Image

With your change:
Image

After adding ellipsize:
Image

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think that the ellipsis takes up useful space and doesn’t look very good. But I’ll accept any decision. I was just curious about why the letters are leaking through.

android:textStyle="bold"
android:textColor="@color/widget_foreground"
android:textSize="14sp"
Expand Down