Skip to content

fix(edit): keep status bar padding after activity recreation - #3392

Open
jancborchardt wants to merge 1 commit into
mainfrom
fix/edit-toolbar-status-bar
Open

jancborchardt wants to merge 1 commit into
mainfrom
fix/edit-toolbar-status-bar

Conversation

@jancborchardt

Copy link
Copy Markdown
Member

A note opened again via a widget or switching back to the app sometimes had the header bar underlap the status bar. This seems to have been due to EditNoteActivity.setImeInsets() only setting bottom padding, which lost top padding needed for the status bar.

🖼️ Screenshots

🏚️ Before 🏡 After
before-2-restored after-2-restored

🏁 Checklist

  • ⛑️ Tests not needed
  • 🔙 Backport requests are created or not needed
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

AI-assistant: Claude Code 2.1.296 (Claude Opus 5.5)
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
@jancborchardt jancborchardt added this to the 35.0.0 milestone Oct 13, 2026
@jancborchardt jancborchardt self-assigned this Oct 13, 2026
@jancborchardt jancborchardt added bug design Design and UX/UI issues 3. to review papercut Annoying recurring UX issue with possibly simple fix. AI assisted labels Oct 13, 2026
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-actions

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/38390565188/artifacts/11811955480
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings back this bug: #2700. We should find fix for both.

@jancborchardt

Copy link
Copy Markdown
Member Author

@alperozturk96 I can’t seem to reproduce, which setup is that? Or what would be your proposal for a fix for both?

@alperozturk96

Copy link
Copy Markdown
Collaborator

@alperozturk96 I can’t seem to reproduce, which setup is that? Or what would be your proposal for a fix for both?

Let me check and update PR if necessary? :)

@jancborchardt

Copy link
Copy Markdown
Member Author

@alperozturk96 I can’t seem to reproduce, which setup is that? Or what would be your proposal for a fix for both?

Let me check and update PR if necessary? :)

Of course, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted bug design Design and UX/UI issues papercut Annoying recurring UX issue with possibly simple fix.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants