Skip to content

chore: migrate to Vitest 5 and fix toolchain blockers - #902

Closed
fengmk2 wants to merge 3 commits into
masterfrom
chore/vitest-5-migration
Closed

fengmk2 wants to merge 3 commits into
masterfrom
chore/vitest-5-migration

Conversation

@fengmk2

@fengmk2 fengmk2 commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

The old benchmark API blocks vp migrate from installing vitest@5.0.1. Benchmarks now use the bench fixture inside test() and run through vp run bench in development and CI.

The toolchain uses the Vite+ preview build 0.0.0-commit.26a6dfe55eadd10931a3f7c38d30a900292ffeed and its registry bridge. Development and CI select supported Node.js versions while the library keeps its public engines.node range. The configuration sets clearMocks: false to preserve existing mock behavior. All setup-vp steps set sfw: false to disable Socket Firewall during dependency installation.

The consumer fixture scripts now compile and execute each fixture instead of rebuilding the root package. Their configurations support typescript@7, and the .mts fixture no longer expects a valid import to fail. The root configurations exclude test/mts, which requires the built package. CI runs vp run build:test to compile and execute the consumer fixtures after the package build.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

socket-security Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​vitest/​coverage-v8@​4.1.11 ⏵ 5.0.19910079 +198 -1100
Updatedvitest@​4.1.11 ⏵ 5.0.198 +110079 +198100

View full report

Comment thread test/mts/src/index.mts
(x: IsAny<any, true, never>) => x; // true

(x: IsAny<typeof responseObj, true, never>) => x; // true
(x: IsAny<typeof responseObj, true, never>) => x; // never
@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.24%. Comparing base (776a8da) to head (dcc067b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #902   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files          10       10           
  Lines         747      747           
  Branches      235      235           
=======================================
  Hits          704      704           
  Misses         40       40           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@902

commit: dcc067b

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@902

commit: 0f692e0

@fengmk2

fengmk2 commented Sep 17, 2026

Copy link
Copy Markdown
Member Author
  • [ ]

@fengmk2 fengmk2 closed this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant